cros: Fold NetworkModel into NetworkScreen

cros: Fold NetworkModel into NetworkScreen

BUG=672142
Review-Url: https://codereview.chromium.org/2649873009
Cr-Commit-Position: refs/heads/master@{#446872}
Committed: https://chromium.googlesource.com/chromium/src/+/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced

[jdufault, 2017-01-26 20:24:05]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 20:24:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 21:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 21:33:23]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-26 21:46:28]

Description was changed from

==========
cros: Fold NetworkModel into NetworkScreen

BUG=
==========

to

==========
cros: Fold NetworkModel into NetworkScreen

BUG=672142
==========

[jdufault, 2017-01-26 21:47:22]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-01-26 21:47:37]

achuith@, PTAL. Thanks!

[achuithb, 2017-01-27 01:20:55]

lgtm

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/network_screen.cc (right):

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/network_screen.cc:174: // BaseScreen
implementation:
This chunk of code just moved right? No changes?

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/network_screen.h (right):

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/network_screen.h:68: std::string
language_list_locale() const { return language_list_locale_; }
const std::string&

[jdufault, 2017-01-27 23:57:31]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-01-27 23:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2649873009/#ps20001
(title: "Address comments")

[jdufault, 2017-01-27 23:57:43]

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/network_screen.cc (right):

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/network_screen.cc:174: // BaseScreen
implementation:
On 2017/01/27 01:20:54, achuithb wrote:
> This chunk of code just moved right? No changes?

Yep

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/network_screen.h (right):

https://codereview.chromium.org/2649873009/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/network_screen.h:68: std::string
language_list_locale() const { return language_list_locale_; }
On 2017/01/27 01:20:54, achuithb wrote:
> const std::string&

Done.

[commit-bot: I haz the power, 2017-01-27 23:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:42:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485561451125970,
"parent_rev": "d11a57aeb74b2f5fee0b8fb7b664a05e3257906c", "commit_rev":
"afd6ce56d8bf38ed03a3c79809c0edb4429c3ced"}

[commit-bot: I haz the power, 2017-01-28 01:43:23]

Description was changed from

==========
cros: Fold NetworkModel into NetworkScreen

BUG=672142
==========

to

==========
cros: Fold NetworkModel into NetworkScreen

BUG=672142

Review-Url: https://codereview.chromium.org/2649873009
Cr-Commit-Position: refs/heads/master@{#446872}
Committed:
https://chromium.googlesource.com/chromium/src/+/afd6ce56d8bf38ed03a3c79809c0...
==========

[commit-bot: I haz the power, 2017-01-28 01:43:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afd6ce56d8bf38ed03a3c79809c0...