Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2657953005: cros: Fold ResetModel into ResetScreen (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fold ResetModel into ResetScreen BUG=672142 Review-Url: https://codereview.chromium.org/2657953005 Cr-Commit-Position: refs/heads/master@{#447921} Committed: https://chromium.googlesource.com/chromium/src/+/c097a72d4f220aeac388197965a1a64aa04a20e6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -105 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/screens/reset_model.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/chromeos/login/screens/reset_model.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 chunk +21 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 3 chunks +8 lines, -12 lines 0 comments Download

Dependent Patchsets:

Issue 2673943002 Patch 1

Messages

Total messages: 15 (10 generated)
jdufault
achuith@, PTAL. Thanks!
3 years, 10 months ago (2017-01-30 19:29:41 UTC) #7
achuithb
lgtm https://codereview.chromium.org/2657953005/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h (right): https://codereview.chromium.org/2657953005/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h#newcode42 chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h:42: // Keeps whether screen should be shown right ...
3 years, 10 months ago (2017-01-30 23:50:58 UTC) #8
jdufault
https://codereview.chromium.org/2657953005/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h (right): https://codereview.chromium.org/2657953005/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h#newcode42 chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h:42: // Keeps whether screen should be shown right after ...
3 years, 10 months ago (2017-02-03 02:39:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657953005/20001
3 years, 10 months ago (2017-02-03 02:39:55 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:06:07 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c097a72d4f220aeac388197965a1...

Powered by Google App Engine
This is Rietveld 408576698