cros: Fold NetworkModel into NetworkScreen

chrome/browser/chromeos/login/screens/network_screen.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screens/network_screen.h"
 
 #include <utility>
 
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 19 matching lines @@
 #include "chromeos/network/network_state_handler.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 // Time in seconds for connection timeout.
 const int kConnectionTimeoutSec = 40;
 
+constexpr const char kUserActionContinueButtonClicked[] = "continue";
+constexpr const char kUserActionConnectDebuggingFeaturesClicked[] =
+    "connect-debugging-features";
+constexpr const char kContextKeyLocale[] = "locale";
+constexpr const char kContextKeyInputMethod[] = "input-method";
+constexpr const char kContextKeyTimezone[] = "timezone";
+constexpr const char kContextKeyContinueButtonEnabled[] =
+    "continue-button-enabled";
+
 }  // namespace
 
 namespace chromeos {
 
 ///////////////////////////////////////////////////////////////////////////////
 // NetworkScreen, public:
 
 // static
 NetworkScreen* NetworkScreen::Get(ScreenManager* manager) {
   return static_cast<NetworkScreen*>(
       manager->GetScreen(OobeScreen::SCREEN_OOBE_NETWORK));
 }
 
 NetworkScreen::NetworkScreen(BaseScreenDelegate* base_screen_delegate,
                              Delegate* delegate,
                              NetworkView* view)
-    : NetworkModel(base_screen_delegate),
-      is_network_subscribed_(false),
-      continue_pressed_(false),
+    : BaseScreen(base_screen_delegate, OobeScreen::SCREEN_OOBE_NETWORK),
       view_(view),
       delegate_(delegate),
       network_state_helper_(new login::NetworkStateHelper),
       weak_factory_(this) {
   if (view_)
-    view_->Bind(*this);
+    view_->Bind(this);
 
   input_method::InputMethodManager::Get()->AddObserver(this);
   InitializeTimezoneObserver();
   OnSystemTimezoneChanged();
   UpdateLanguageList();
 }
 
 NetworkScreen::~NetworkScreen() {
   if (view_)
     view_->Unbind();
   connection_timer_.Stop();
   UnsubscribeNetworkNotification();
 
   input_method::InputMethodManager::Get()->RemoveObserver(this);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-// NetworkScreen, NetworkModel implementation:
-
-void NetworkScreen::Show() {
-  Refresh();
-
-  // Here we should handle default locales, for which we do not have UI
-  // resources. This would load fallback, but properly show "selected" locale
-  // in the UI.
-  if (selected_language_code_.empty()) {
-    const StartupCustomizationDocument* startup_manifest =
-        StartupCustomizationDocument::GetInstance();
-    SetApplicationLocale(startup_manifest->initial_locale_default());
-  }
-
-  if (!timezone_subscription_)
-    InitializeTimezoneObserver();
-
-  if (view_)
-    view_->Show();
-}
-
-void NetworkScreen::Hide() {
-  timezone_subscription_.reset();
-  if (view_)
-    view_->Hide();
-}
+// NetworkScreen, public API, setters and getters for input method and timezone.
 
 void NetworkScreen::OnViewDestroyed(NetworkView* view) {
   if (view_ == view) {
     view_ = nullptr;
     timezone_subscription_.reset();
     // Ownership of NetworkScreen is complicated; ensure that we remove
     // this as a NetworkStateHandler observer when the view is destroyed.
     UnsubscribeNetworkNotification();
   }
 }
 
-void NetworkScreen::OnUserAction(const std::string& action_id) {
-  if (action_id == kUserActionContinueButtonClicked) {
-    OnContinueButtonPressed();
-  } else if (action_id == kUserActionConnectDebuggingFeaturesClicked) {
-    if (delegate_)
-      delegate_->OnEnableDebuggingScreenRequested();
-  } else {
-    BaseScreen::OnUserAction(action_id);
-  }
-}
-
-void NetworkScreen::OnContextKeyUpdated(
-    const ::login::ScreenContext::KeyType& key) {
-  if (key == kContextKeyLocale)
-    SetApplicationLocale(context_.GetString(kContextKeyLocale));
-  else if (key == kContextKeyInputMethod)
-    SetInputMethod(context_.GetString(kContextKeyInputMethod));
-  else if (key == kContextKeyTimezone)
-    SetTimezone(context_.GetString(kContextKeyTimezone));
-  else
-    NetworkModel::OnContextKeyUpdated(key);
-}
-
-std::string NetworkScreen::GetLanguageListLocale() const {
-  return language_list_locale_;
-}
-
-const base::ListValue* NetworkScreen::GetLanguageList() const {
-  return language_list_.get();
-}
 
 void NetworkScreen::UpdateLanguageList() {
   ScheduleResolveLanguageList(
       std::unique_ptr<locale_util::LanguageSwitchResult>());
 }
 
-////////////////////////////////////////////////////////////////////////////////
-// NetworkScreen, NetworkStateHandlerObserver implementation:
-
-void NetworkScreen::NetworkConnectionStateChanged(const NetworkState* network) {
-  UpdateStatus();
-}
-
-void NetworkScreen::DefaultNetworkChanged(const NetworkState* network) {
-  UpdateStatus();
-}
-
-////////////////////////////////////////////////////////////////////////////////
-// NetworkScreen, InputMethodManager::Observer implementation:
-
-void NetworkScreen::InputMethodChanged(
-    input_method::InputMethodManager* manager,
-    Profile* /* proflie */,
-    bool /* show_message */) {
-  GetContextEditor().SetString(
-      kContextKeyInputMethod,
-      manager->GetActiveIMEState()->GetCurrentInputMethod().id());
-}
-
-////////////////////////////////////////////////////////////////////////////////
-// NetworkScreen, setters and getters for input method and timezone.
-
 void NetworkScreen::SetApplicationLocaleAndInputMethod(
     const std::string& locale,
     const std::string& input_method) {
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
   if (app_locale == locale || locale.empty()) {
     // If the locale doesn't change, set input method directly.
     SetInputMethod(input_method);
     return;
   }
 
@@ skipping 47 matching lines @@
   if (observer)
     observers_.AddObserver(observer);
 }
 
 void NetworkScreen::RemoveObserver(Observer* observer) {
   if (observer)
     observers_.RemoveObserver(observer);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
+// BaseScreen implementation:

[achuithb, 2017/01/27 01:20:54]

This chunk of code just moved right? No changes?

[jdufault, 2017/01/27 23:57:43]

Yep

+
+void NetworkScreen::Show() {
+  Refresh();
+
+  // Here we should handle default locales, for which we do not have UI
+  // resources. This would load fallback, but properly show "selected" locale
+  // in the UI.
+  if (selected_language_code_.empty()) {
+    const StartupCustomizationDocument* startup_manifest =
+        StartupCustomizationDocument::GetInstance();
+    SetApplicationLocale(startup_manifest->initial_locale_default());
+  }
+
+  if (!timezone_subscription_)
+    InitializeTimezoneObserver();
+
+  if (view_)
+    view_->Show();
+}
+
+void NetworkScreen::Hide() {
+  timezone_subscription_.reset();
+  if (view_)
+    view_->Hide();
+}
+
+void NetworkScreen::OnUserAction(const std::string& action_id) {
+  if (action_id == kUserActionContinueButtonClicked) {
+    OnContinueButtonPressed();
+  } else if (action_id == kUserActionConnectDebuggingFeaturesClicked) {
+    if (delegate_)
+      delegate_->OnEnableDebuggingScreenRequested();
+  } else {
+    BaseScreen::OnUserAction(action_id);
+  }
+}
+
+void NetworkScreen::OnContextKeyUpdated(
+    const ::login::ScreenContext::KeyType& key) {
+  if (key == kContextKeyLocale)
+    SetApplicationLocale(context_.GetString(kContextKeyLocale));
+  else if (key == kContextKeyInputMethod)
+    SetInputMethod(context_.GetString(kContextKeyInputMethod));
+  else if (key == kContextKeyTimezone)
+    SetTimezone(context_.GetString(kContextKeyTimezone));
+  else
+    BaseScreen::OnContextKeyUpdated(key);
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// NetworkScreen, NetworkStateHandlerObserver implementation:
+
+void NetworkScreen::NetworkConnectionStateChanged(const NetworkState* network) {
+  UpdateStatus();
+}
+
+void NetworkScreen::DefaultNetworkChanged(const NetworkState* network) {
+  UpdateStatus();
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// NetworkScreen, InputMethodManager::Observer implementation:
+
+void NetworkScreen::InputMethodChanged(
+    input_method::InputMethodManager* manager,
+    Profile* /* proflie */,
+    bool /* show_message */) {
+  GetContextEditor().SetString(
+      kContextKeyInputMethod,
+      manager->GetActiveIMEState()->GetCurrentInputMethod().id());
+}
+
+////////////////////////////////////////////////////////////////////////////////
 // NetworkScreen, private:
 
 void NetworkScreen::SetApplicationLocale(const std::string& locale) {
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
   if (app_locale == locale || locale.empty())
     return;
 
   // Block UI while resource bundle is being reloaded.
   // (InputEventsBlocker will live until callback is finished.)
   locale_util::SwitchLanguageCallback callback(base::Bind(
@@ skipping 182 matching lines @@
     observer.OnLanguageListReloaded();
 }
 
 void NetworkScreen::OnSystemTimezoneChanged() {
   std::string current_timezone_id;
   CrosSettings::Get()->GetString(kSystemTimezone, &current_timezone_id);
   GetContextEditor().SetString(kContextKeyTimezone, current_timezone_id);
 }
 
 }  // namespace chromeos