[Predator] Switch from scorer-based classifier to loglinear classifier.

[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and log linear classifier are the same.

TBR=stgao@chromium.org
BUG=679964
Review-Url: https://codereview.chromium.org/2649503002
Committed: https://chromium.googlesource.com/infra/infra/+/1dbde588d56f7a0b5640a361283682c4fac43cfe

[Sharu Jiang, 2017-01-31 00:15:31]

Patchset #1 (id:1) has been deleted

[Sharu Jiang, 2017-01-31 00:22:25]

Description was changed from

==========
[Predator] Switch to loglinear classifier.

BUG=679964
==========

to

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

BUG=679964
==========

[Sharu Jiang, 2017-01-31 00:22:25]

katesonia@chromium.org changed reviewers:
+ mbarbella@chromium.org, wrengr@chromium.org

[Sharu Jiang, 2017-01-31 00:24:28]

PTAL.

[wrengr, 2017-01-31 19:42:11]

Code lgtm. Have you run the delta tests to see how it compares? If so, is there
a log/report of that anywhere?

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
File appengine/findit/crash/findit_for_chromecrash.py (right):

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
appengine/findit/crash/findit_for_chromecrash.py:62: meta_weight = MetaWeight({
This is fine for now, but eventually we'll want to take the weights in as an
argument so that we can read them from a config somewhere rather than hardcoding
them

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
appengine/findit/crash/findit_for_chromecrash.py:82: #
TODO(http://crbug.com/679964) Deprecate the scorer-based changelist
This todo is redundant now

[Sharu Jiang, 2017-02-01 19:32:40]

Right now I am in the middle of another big cl, and I cannot make any local
changes during the delta test(and it takes long time to run many testcases),
will do delta test after upload the cl.

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
File appengine/findit/crash/findit_for_chromecrash.py (right):

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
appengine/findit/crash/findit_for_chromecrash.py:62: meta_weight = MetaWeight({
On 2017/01/31 19:42:11, wrengr wrote:
> This is fine for now, but eventually we'll want to take the weights in as an
> argument so that we can read them from a config somewhere rather than
hardcoding
> them

Acknowledged. Added a todo.

https://codereview.chromium.org/2649503002/diff/40001/appengine/findit/crash/...
appengine/findit/crash/findit_for_chromecrash.py:82: #
TODO(http://crbug.com/679964) Deprecate the scorer-based changelist
On 2017/01/31 19:42:11, wrengr wrote:
> This todo is redundant now

Done.

[Sharu Jiang, 2017-02-07 22:03:24]

Delta test results on 100 crashes showed the scorer-based classifier and log
linear classifier are the same.

[Sharu Jiang, 2017-02-07 22:03:35]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2017-02-07 22:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from wrengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2649503002/#ps80001
(title: "Rebase and fix bug.")

[commit-bot: I haz the power, 2017-02-07 22:03:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:03:48]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[Sharu Jiang, 2017-02-07 22:05:56]

katesonia@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[Sharu Jiang, 2017-02-07 22:05:56]

PTAL.

[Sharu Jiang, 2017-02-07 22:06:32]

Description was changed from

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

BUG=679964
==========

to

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and
log linear classifier are the same.

BUG=679964
==========

[wrengr, 2017-02-07 22:09:32]

On 2017/02/07 22:05:56, Sharu Jiang wrote:
> PTAL.

I think you may want to TBR stgao. Not sure if anyone else has the commit bit.

[Sharu Jiang, 2017-02-07 22:27:01]

Description was changed from

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and
log linear classifier are the same.

BUG=679964
==========

to

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and
log linear classifier are the same.

TBR=stgao@chromium.org
BUG=679964
==========

[Sharu Jiang, 2017-02-07 23:52:23]

Patchset #4 (id:80001) has been deleted

[Sharu Jiang, 2017-02-07 23:54:42]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2017-02-07 23:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from wrengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2649503002/#ps140001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-02-07 23:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:03:24]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1486511682512360,
"parent_rev": "4bea196f505f00cca41d8c90a0a2f71b73b73afa", "commit_rev":
"1dbde588d56f7a0b5640a361283682c4fac43cfe"}

[commit-bot: I haz the power, 2017-02-08 00:03:28]

Description was changed from

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and
log linear classifier are the same.

TBR=stgao@chromium.org
BUG=679964
==========

to

==========
[Predator] Switch from scorer-based classifier to loglinear classifier.

Delta test results on 100 crashes showed that the scorer-based classifier and
log linear classifier are the same.

TBR=stgao@chromium.org
BUG=679964

Review-Url: https://codereview.chromium.org/2649503002
Committed:
https://chromium.googlesource.com/infra/infra/+/1dbde588d56f7a0b5640a36128368...
==========

[commit-bot: I haz the power, 2017-02-08 00:03:29]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/infra/infra/+/1dbde588d56f7a0b5640a36128368...