Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2133)

Unified Diff: appengine/findit/crash/test/occurrence_test.py

Issue 2649503002: [Predator] Switch from scorer-based classifier to loglinear classifier. (Closed)
Patch Set: Fix nits. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/occurrence_test.py
diff --git a/appengine/findit/crash/test/occurrence_test.py b/appengine/findit/crash/test/occurrence_test.py
index 9b3b45856ee73b67536446b461f36a9a513f367d..61e2583a435f6e3a1c43f564e0a0e3c6003ea96f 100644
--- a/appengine/findit/crash/test/occurrence_test.py
+++ b/appengine/findit/crash/test/occurrence_test.py
@@ -19,6 +19,9 @@ class DummyClassifier(object):
if frame.dep_path == 'src/':
return 'class_1'
+ if frame.dep_path == 'dummy/':
+ return None
+
return 'class_2'
def GetClassFromSuspect(self, _result): # pragma: no cover.
@@ -56,7 +59,8 @@ class ClassifierTest(PredatorTestCase):
crash_stack = CallStack(0, frame_list=[
StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
- StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
+ StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87]),
+ StackFrame(3, 'dummy/', 'a::g(int)', 'f3.cc', 'src/f3.cc', [87])])
self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_1')
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698