Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: appengine/findit/crash/test/occurrence_test.py

Issue 2649503002: [Predator] Switch from scorer-based classifier to loglinear classifier. (Closed)
Patch Set: Fix nits. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common import constants 5 from common import constants
6 from common.pipeline_wrapper import pipeline_handlers 6 from common.pipeline_wrapper import pipeline_handlers
7 from crash.occurrence import Occurrence 7 from crash.occurrence import Occurrence
8 from crash.occurrence import DefaultOccurrenceRanking 8 from crash.occurrence import DefaultOccurrenceRanking
9 from crash.occurrence import RankByOccurrence 9 from crash.occurrence import RankByOccurrence
10 from crash.stacktrace import StackFrame 10 from crash.stacktrace import StackFrame
11 from crash.stacktrace import CallStack 11 from crash.stacktrace import CallStack
12 from crash.suspect import Suspect 12 from crash.suspect import Suspect
13 from crash.test.predator_testcase import PredatorTestCase 13 from crash.test.predator_testcase import PredatorTestCase
14 14
15 15
16 class DummyClassifier(object): 16 class DummyClassifier(object):
17 17
18 def GetClassFromStackFrame(self, frame): 18 def GetClassFromStackFrame(self, frame):
19 if frame.dep_path == 'src/': 19 if frame.dep_path == 'src/':
20 return 'class_1' 20 return 'class_1'
21 21
22 if frame.dep_path == 'dummy/':
23 return None
24
22 return 'class_2' 25 return 'class_2'
23 26
24 def GetClassFromSuspect(self, _result): # pragma: no cover. 27 def GetClassFromSuspect(self, _result): # pragma: no cover.
25 return 'class_3' 28 return 'class_3'
26 29
27 def Classify(self, results, crash_stack): 30 def Classify(self, results, crash_stack):
28 top_n_frames = 4 31 top_n_frames = 4
29 if results: 32 if results:
30 classes = map(self.GetClassFromSuspect, results[:top_n_frames]) 33 classes = map(self.GetClassFromSuspect, results[:top_n_frames])
31 else: 34 else:
(...skipping 17 matching lines...) Expand all
49 52
50 def testClassifyCrashStack(self): 53 def testClassifyCrashStack(self):
51 dummy_classifier = DummyClassifier() 54 dummy_classifier = DummyClassifier()
52 55
53 crash_stack = CallStack(0) 56 crash_stack = CallStack(0)
54 self.assertEqual(dummy_classifier.Classify([], crash_stack), '') 57 self.assertEqual(dummy_classifier.Classify([], crash_stack), '')
55 58
56 crash_stack = CallStack(0, frame_list=[ 59 crash_stack = CallStack(0, frame_list=[
57 StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]), 60 StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
58 StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]), 61 StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
59 StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])]) 62 StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87]),
63 StackFrame(3, 'dummy/', 'a::g(int)', 'f3.cc', 'src/f3.cc', [87])])
60 64
61 self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_1') 65 self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_1')
62 66
63 crash_stack = CallStack(0, frame_list=[ 67 crash_stack = CallStack(0, frame_list=[
64 StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]), 68 StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
65 StackFrame(1, 'src/dummy', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]), 69 StackFrame(1, 'src/dummy', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
66 StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])]) 70 StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
67 71
68 self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_2') 72 self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_2')
69 73
70 def testClassifySuspects(self): 74 def testClassifySuspects(self):
71 dummy_classifier = DummyClassifier() 75 dummy_classifier = DummyClassifier()
72 76
73 suspect = Suspect(self.GetDummyChangeLog(), 'src/') 77 suspect = Suspect(self.GetDummyChangeLog(), 'src/')
74 suspect.file_to_stack_infos = { 78 suspect.file_to_stack_infos = {
75 'f0.cc': [(StackFrame( 79 'f0.cc': [(StackFrame(
76 0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]), 0)] 80 0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]), 0)]
77 } 81 }
78 82
79 self.assertEqual(dummy_classifier.Classify([suspect], CallStack(0)), 83 self.assertEqual(dummy_classifier.Classify([suspect], CallStack(0)),
80 'class_3') 84 'class_3')
81 85
OLDNEW
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698