Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2648893002: Remove remaining traces of CreateGpuMemoryBufferImageCHROMIUM (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, danakj+watch_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, posciak+watch_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, feature-media-reviews_chromium.org, Rik, f(malita), piman+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, ajuma+watch_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining traces of CreateGpuMemoryBufferImageCHROMIUM We use the GpuMemoryBuffer API directly, making this redundant. R=zmo,sandersd TBR=bbudge,pdr (OWNERs mechanical change paths) BUG=648707 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2648893002 Cr-Commit-Position: refs/heads/master@{#448911} Committed: https://chromium.googlesource.com/chromium/src/+/a432af1882f7097be6b332b9e8186f8bc98fb279

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase, but don't pull in extra changes... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -449 lines) Patch
M cc/test/test_gles2_interface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/test_gles2_interface.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/display_compositor/buffer_queue.h View 1 chunk +3 lines, -3 lines 0 comments Download
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt View 1 chunk +0 lines, -73 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_420v_image.txt View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycrcb_420_image.txt View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 2 2 chunks +0 lines, -22 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +0 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 3 2 chunks +0 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 3 chunks +1 line, -79 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +1 line, -39 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/common/gpu_memory_buffer_support.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M media/renderers/video_overlay_factory.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes3D.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 39 (32 generated)
ccameron
Burning with fire.
3 years, 11 months ago (2017-01-26 00:11:49 UTC) #17
ccameron
Adding sandersd for media/
3 years, 11 months ago (2017-01-26 00:15:37 UTC) #19
sandersd (OOO until July 31)
media/ lgtm.
3 years, 11 months ago (2017-01-26 00:18:11 UTC) #20
Zhenyao Mo
On 2017/01/26 00:18:11, sandersd wrote: > media/ lgtm. sweet lgtm
3 years, 11 months ago (2017-01-26 19:19:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648893002/60001
3 years, 10 months ago (2017-02-08 02:53:20 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648893002/80001
3 years, 10 months ago (2017-02-08 03:07:19 UTC) #36
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 05:13:41 UTC) #39
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a432af1882f7097be6b332b9e818...

Powered by Google App Engine
This is Rietveld 408576698