gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc - Issue 2648893002: Remove remaining traces of CreateGpuMemoryBufferImageCHROMIUM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc

Issue 2648893002: Remove remaining traces of CreateGpuMemoryBufferImageCHROMIUM (Closed)

Patch Set: Rebase, but don't pull in extra changes... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h ('k') | gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc b/gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc

index 050fc42c36f78cd4f1f54c60ff3091cb5a405b72..5ac0567fc5942dd85a97e656e3600899ff8535b6 100644

--- a/gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc

+++ b/gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc

@@ -117,8 +117,10 @@ TEST_P(GLCopyTexImage2DWorkaroundTest, UseIntermediaryTexture) {

glBindTexture(source_target, source_texture);

glTexParameteri(source_target, GL_TEXTURE_MIN_FILTER, GL_LINEAR);

glTexParameteri(source_target, GL_TEXTURE_MAG_FILTER, GL_LINEAR);

- GLuint image_id = glCreateGpuMemoryBufferImageCHROMIUM(

- width, height, GL_RGBA, GL_READ_WRITE_CHROMIUM);

+ std::unique_ptr<gfx::GpuMemoryBuffer> buffer(gl_.CreateGpuMemoryBuffer(

+ gfx::Size(width, height), gfx::BufferFormat::RGBA_8888));

+ GLuint image_id =

+ glCreateImageCHROMIUM(buffer->AsClientBuffer(), width, height, GL_RGBA);

ASSERT_NE(0u, image_id);

glBindTexImage2DCHROMIUM(source_target, image_id);