Move exportable_commits_since to webkitpy/w3c/common.py.

Move exportable_commits_since to webkitpy/w3c/common.py.

Purpose: This is a refactoring CL to make it easier to use exportable_commits_since in order to abort if there are exportable and not exported commits when importing.

BUG=666540
Review-Url: https://codereview.chromium.org/2648783004
Cr-Commit-Position: refs/heads/master@{#445194}
Committed: https://chromium.googlesource.com/chromium/src/+/5a067632aa54e3ac8c068778e7043cbc19b48121

[qyearsley, 2017-01-20 19:52:37]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-01-20 19:54:18]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:54:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-01-20 19:55:00]

Description was changed from

==========
Move exportable_commits_since to webkitpy/w3c/common.py.

BUG=666540
==========

to

==========
Move exportable_commits_since to webkitpy/w3c/common.py.

Purpose: This is a refactoring CL to make it easier to use
exportable_commits_since in order to abort if there are exportable and not
exported commits when importing.

BUG=666540
==========

[commit-bot: I haz the power, 2017-01-20 20:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:56:26]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2017-01-20 22:22:56]

lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm

https://codereview.chromium.org/2648783004/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py (right):

https://codereview.chromium.org/2648783004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py:13: #
TODO(qyearsley): Move this to executive_mock.
Would it be cleaner if we integrated this functionality into MockExecutive
itself? e.g. to be able to pass it a list of expected arguments & their
corresponding outputs.

[qyearsley, 2017-01-20 22:40:02]

Wah, wall of lgtm :-P

https://codereview.chromium.org/2648783004/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py (right):

https://codereview.chromium.org/2648783004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py:13: #
TODO(qyearsley): Move this to executive_mock.
On 2017/01/20 at 22:22:55, jeffcarp wrote:
> Would it be cleaner if we integrated this functionality into MockExecutive
itself? e.g. to be able to pass it a list of expected arguments & their
corresponding outputs.

Yeah, that sounds like a good idea - in this case we're wanting to map
specifically from git subcommands to values, although in the general case we
might want to map from commands or full args lists to values... so now I'm not
sure what's the best way to do it. Maybe it will actually be better to just
leave this here...

[qyearsley, 2017-01-20 22:40:06]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:40:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:46:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484952006545350, "parent_rev":
"ffd1a8bafeebab1509c83bd37cda834a0a15053e", "commit_rev":
"5a067632aa54e3ac8c068778e7043cbc19b48121"}

[commit-bot: I haz the power, 2017-01-20 22:46:44]

Description was changed from

==========
Move exportable_commits_since to webkitpy/w3c/common.py.

Purpose: This is a refactoring CL to make it easier to use
exportable_commits_since in order to abort if there are exportable and not
exported commits when importing.

BUG=666540
==========

to

==========
Move exportable_commits_since to webkitpy/w3c/common.py.

Purpose: This is a refactoring CL to make it easier to use
exportable_commits_since in order to abort if there are exportable and not
exported commits when importing.

BUG=666540

Review-Url: https://codereview.chromium.org/2648783004
Cr-Commit-Position: refs/heads/master@{#445194}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a067632aa54e3ac8c068778e704...
==========

[commit-bot: I haz the power, 2017-01-20 22:46:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a067632aa54e3ac8c068778e704...