Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

Issue 2648783004: Move exportable_commits_since to webkitpy/w3c/common.py. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
index 1952e616b95d58b8ee4ca85adf9fb2a9d80c5dee..76e48ec83bd7a21ae46024d2ffe474c07c1d8d9a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
@@ -4,7 +4,6 @@
from webkitpy.common.memoized import memoized
from webkitpy.common.webkit_finder import WebKitFinder
-from webkitpy.w3c.deps_updater import DepsUpdater
CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'
@@ -81,7 +80,13 @@ class ChromiumCommit(object):
self.host.filesystem.join('resources', 'testharnessreport.js'),
]
qualified_blacklist = [CHROMIUM_WPT_DIR + f for f in blacklist]
- return [f for f in changed_files if f not in qualified_blacklist and not DepsUpdater.is_baseline(f)]
+
+ return [f for f in changed_files if f not in qualified_blacklist and not self.is_baseline(f)]
+
+ @staticmethod
+ def is_baseline(basename):
+ # TODO(qyearsley): Find a better, centralized place for this.
+ return basename.endswith('-expected.txt')
def format_patch(self):
"""Makes a patch with only exportable changes."""

Powered by Google App Engine
This is Rietveld 408576698