third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py - Issue 2648783004: Move exportable_commits_since to webkitpy/w3c/common.py.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

Issue 2648783004: Move exportable_commits_since to webkitpy/w3c/common.py. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import unittest	5 import unittest

6	6

7 from webkitpy.common.host_mock import MockHost	7 from webkitpy.common.host_mock import MockHost

8 from webkitpy.common.system.executive_mock import MockExecutive	8 from webkitpy.common.system.executive_mock import MockExecutive

9 from webkitpy.w3c.chromium_commit import ChromiumCommit	9 from webkitpy.w3c.chromium_commit import ChromiumCommit

10 from webkitpy.w3c.test_exporter_unittest import mock_command_exec	10 from webkitpy.w3c.common_unittest import mock_command_exec

11	11

12 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'	12 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'

13	13

14	14

15 class ChromiumCommitTest(unittest.TestCase):	15 class ChromiumCommitTest(unittest.TestCase):

16	16

17 def test_accepts_sha(self):	17 def test_accepts_sha(self):

18 chromium_commit = ChromiumCommit(MockHost(), sha='deadbeefcafe')	18 chromium_commit = ChromiumCommit(MockHost(), sha='deadbeefcafe')

19	19

20 self.assertEqual(chromium_commit.sha, 'deadbeefcafe')	20 self.assertEqual(chromium_commit.sha, 'deadbeefcafe')

(...skipping 21 matching lines...) Expand all Loading...
42	42

43 position_footer = 'Cr-Commit-Position: refs/heads/master@{#789}'	43 position_footer = 'Cr-Commit-Position: refs/heads/master@{#789}'

44 chromium_commit = ChromiumCommit(host, position=position_footer)	44 chromium_commit = ChromiumCommit(host, position=position_footer)

45	45

46 files = chromium_commit.filtered_changed_files()	46 files = chromium_commit.filtered_changed_files()

47	47

48 expected_files = ['file1', 'file3']	48 expected_files = ['file1', 'file3']

49 qualified_expected_files = [CHROMIUM_WPT_DIR + f for f in expected_files ]	49 qualified_expected_files = [CHROMIUM_WPT_DIR + f for f in expected_files ]

50	50

51 self.assertEqual(files, qualified_expected_files)	51 self.assertEqual(files, qualified_expected_files)

OLD	NEW