chromeos: Rename various CreateShelf methods to CreateShelfView

chromeos: Rename various CreateShelf methods to CreateShelfView

Shelf construction is confusing: WmShelf is created immediately for each
RootWindowController and ShelfWidget shortly thereafter. The ShelfView, on
the other hand, is only created after login.

Attempt to clarify the situation by renaming a bunch of "CreateShelf"
methods to CreateShelfView. This exposed a couple other refactors that I
tagged with TODOs.

No functional changes.

BUG=679925
TEST=ash_unittests
TBR=xdai@chromium.org

Review-Url: https://codereview.chromium.org/2648483002
Cr-Commit-Position: refs/heads/master@{#444782}
Committed: https://chromium.googlesource.com/chromium/src/+/072742fba50cd351ef4b7d7b4b73f348b157ddef

[James Cook, 2017-01-19 06:01:29]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2017-01-19 06:02:13]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-01-19 06:02:14]

msw, please take a look. Gosh, shelf initialization is a mess. :-)

[commit-bot: I haz the power, 2017-01-19 06:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 06:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 06:32:27]

Dry run: This issue passed the CQ dry run.

[msw, 2017-01-19 09:54:26]

lgtm with an aside

https://codereview.chromium.org/2648483002/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2648483002/diff/1/ash/root_window_controller....
ash/root_window_controller.cc:363: // TODO(jamescook): Pass |wm_shelf_| into the
constructors for these layout
aside: maybe, unless they depend on the shelf view when this is called.

[James Cook, 2017-01-19 17:31:35]

Thanks for the late-night review!

https://codereview.chromium.org/2648483002/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2648483002/diff/1/ash/root_window_controller....
ash/root_window_controller.cc:363: // TODO(jamescook): Pass |wm_shelf_| into the
constructors for these layout
On 2017/01/19 09:54:26, msw (out 1-19) wrote:
> aside: maybe, unless they depend on the shelf view when this is called.

Yeah, that's why I didn't do it here. The SetShelf() methods in both cases have
some side-effects (like refreshing layout state or adding observers). I'll need
to analyze them in more detail.

[James Cook, 2017-01-19 17:31:42]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:32:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:40:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2017-01-19 17:51:14]

Description was changed from

==========
chromeos: Rename various CreateShelf methods to CreateShelfView

Shelf construction is confusing: WmShelf is created immediately for each
RootWindowController and ShelfWidget shortly thereafter. The ShelfView, on
the other hand, is only created after login.

Attempt to clarify the situation by renaming a bunch of "CreateShelf"
methods to CreateShelfView. This exposed a couple other refactors that I
tagged with TODOs.

No functional changes.

BUG=679925
TEST=ash_unittests
==========

to

==========
chromeos: Rename various CreateShelf methods to CreateShelfView

Shelf construction is confusing: WmShelf is created immediately for each
RootWindowController and ShelfWidget shortly thereafter. The ShelfView, on
the other hand, is only created after login.

Attempt to clarify the situation by renaming a bunch of "CreateShelf"
methods to CreateShelfView. This exposed a couple other refactors that I
tagged with TODOs.

No functional changes.

BUG=679925
TEST=ash_unittests
TBR=xdai@chromium.org
==========

[James Cook, 2017-01-19 17:51:42]

jamescook@chromium.org changed reviewers:
+ xdai@chromium.org

[James Cook, 2017-01-19 17:51:42]

TBR xdai for trivial rename touching c/b/chromeos/login/users/wallpaper

[James Cook, 2017-01-19 17:51:46]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:52:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:58:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484848306290740, "parent_rev":
"054f78b8996675673b5dab034b5b7f2698e4e9d5", "commit_rev":
"072742fba50cd351ef4b7d7b4b73f348b157ddef"}

[commit-bot: I haz the power, 2017-01-19 17:58:50]

Description was changed from

==========
chromeos: Rename various CreateShelf methods to CreateShelfView

Shelf construction is confusing: WmShelf is created immediately for each
RootWindowController and ShelfWidget shortly thereafter. The ShelfView, on
the other hand, is only created after login.

Attempt to clarify the situation by renaming a bunch of "CreateShelf"
methods to CreateShelfView. This exposed a couple other refactors that I
tagged with TODOs.

No functional changes.

BUG=679925
TEST=ash_unittests
TBR=xdai@chromium.org
==========

to

==========
chromeos: Rename various CreateShelf methods to CreateShelfView

Shelf construction is confusing: WmShelf is created immediately for each
RootWindowController and ShelfWidget shortly thereafter. The ShelfView, on
the other hand, is only created after login.

Attempt to clarify the situation by renaming a bunch of "CreateShelf"
methods to CreateShelfView. This exposed a couple other refactors that I
tagged with TODOs.

No functional changes.

BUG=679925
TEST=ash_unittests
TBR=xdai@chromium.org

Review-Url: https://codereview.chromium.org/2648483002
Cr-Commit-Position: refs/heads/master@{#444782}
Committed:
https://chromium.googlesource.com/chromium/src/+/072742fba50cd351ef4b7d7b4b73...
==========

[commit-bot: I haz the power, 2017-01-19 17:58:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/072742fba50cd351ef4b7d7b4b73...