chromeos: Rename various CreateShelf methods to CreateShelfView

ash/root_window_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include <algorithm>
 #include <queue>
 #include <vector>
 
@@ skipping 337 matching lines @@
 }
 
 bool RootWindowController::HasShelf() {
   return wm_shelf_->shelf_widget() != nullptr;
 }
 
 WmShelf* RootWindowController::GetShelf() {
   return wm_shelf_.get();
 }
 
-void RootWindowController::CreateShelf() {
+void RootWindowController::CreateShelfView() {
   if (wm_shelf_->IsShelfInitialized())
     return;
-  wm_shelf_->InitializeShelf();
+  wm_shelf_->CreateShelfView();
 
+  // TODO(jamescook): Pass |wm_shelf_| into the constructors for these layout

[msw, 2017/01/19 09:54:26]

aside: maybe, unless they depend on the shelf view when this is called.

[James Cook, 2017/01/19 17:31:34]

Yeah, that's why I didn't do it here. The SetShelf() methods in both cases have
some side-effects (like refreshing layout state or adding observers). I'll need
to analyze them in more detail.

+  // managers.
   if (panel_layout_manager_)
     panel_layout_manager_->SetShelf(wm_shelf_.get());
   if (docked_window_layout_manager_) {
     docked_window_layout_manager_->SetShelf(wm_shelf_.get());
     if (wm_shelf_->shelf_layout_manager())
       docked_window_layout_manager_->AddObserver(
           wm_shelf_->shelf_layout_manager());
   }
 
   // Notify shell observers that the shelf has been created.
@@ skipping 420 matching lines @@
 
   root_window_layout_manager_->OnWindowResized();
   if (root_window_type == RootWindowType::PRIMARY) {
     if (!wm_shell->IsRunningInMash())
       shell->InitKeyboard();
   } else {
     window_tree_host_->Show();
 
     // Create a shelf if a user is already logged in.
     if (wm_shell->GetSessionStateDelegate()->NumberOfLoggedInUsers())
-      CreateShelf();
+      CreateShelfView();
 
     // Notify shell observers about new root window.
     shell->OnRootWindowAdded(WmWindow::Get(root_window));
   }
 
   // TODO: AshTouchExplorationManager doesn't work with mus.
   // http://crbug.com/679782
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kAshDisableTouchExplorationMode) &&
       !wm_shell->IsRunningInMash()) {
@@ skipping 326 matching lines @@
     EnableTouchHudProjection();
   else
     DisableTouchHudProjection();
 }
 
 RootWindowController* GetRootWindowController(const aura::Window* root_window) {
   return root_window ? GetRootWindowSettings(root_window)->controller : nullptr;
 }
 
 }  // namespace ash