Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2648423002: Rename feature policy classes. (Closed)

Created:
3 years, 11 months ago by iclelland
Modified:
3 years, 10 months ago
Reviewers:
Mike West, raymes, pfeldman
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, iclelland, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, lunalu1, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename feature policy classes. Previously, we were using the term 'whitelist' to refer to what is more correctly a feature policy declaration (a feature name and a whitelist of origins), and overloading the term 'feature policy' to refer to the contents of a feature policy header (a collection of declarations). This CL tries to rationalize the terminology used for class naming in blink and in content. This is part 1 of 5 in the effort to move the FeaturePolicy implementation into the content layer, which will facilitate use of the framework for browser- based policy decisions. See the other CLs in this series: [1/5] (This CL) (Rename classes) [2/5] https://codereview.chromium.org/2654873004/ (Centralize content-side code) [3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in browser) [4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink) [5/5] https://codereview.chromium.org/2656533004/ (Remove unused blink code.) BUG=685195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2648423002 Cr-Commit-Position: refs/heads/master@{#447885} Committed: https://chromium.googlesource.com/chromium/src/+/4dbcfdcb2ce26ac7f1a3effa09631053fe5a224a

Patch Set 1 #

Patch Set 2 : Rename content classes to better match blink ones #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -110 lines) Patch
M content/browser/frame_host/frame_tree_node.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M content/common/frame_messages.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/frame_replication_state.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M content/common/frame_replication_state.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 4 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp View 1 chunk +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFeaturePolicy.h View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
iclelland
+r raymes -- First part (of several) splitting up the monster CL in https://codereview.chromium.org/2636843003/ into ...
3 years, 11 months ago (2017-01-24 20:37:25 UTC) #11
raymes
lgtm
3 years, 11 months ago (2017-01-25 00:54:24 UTC) #12
iclelland
+r mkwst for frame_messages.h +r pfeldman, can you take a look as OWNER for everything ...
3 years, 10 months ago (2017-01-27 20:13:43 UTC) #15
pfeldman
lgtm
3 years, 10 months ago (2017-01-27 22:10:24 UTC) #16
Mike West
LGTM.
3 years, 10 months ago (2017-02-02 20:52:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648423002/40001
3 years, 10 months ago (2017-02-02 21:49:23 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:52:35 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4dbcfdcb2ce26ac7f1a3effa0963...

Powered by Google App Engine
This is Rietveld 408576698