Move content-side Feature Policy code into content/{common,child}/feature_policy

Move content-side Feature Policy code into content/{common,child}/feature_policy

This is part 2 of 5 in the effort to move the FeaturePolicy implementation
into the content layer, which will facilitate use of the framework for browser-
based policy decisions.

See the other CLs in this series:
[1/5] https://codereview.chromium.org/2648423002/ (Rename classes)
[2/5] (This CL)                                   (Centralize content-side code)
[3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in browser)
[4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink)
[5/5] https://codereview.chromium.org/2656533004/ (Remove unused blink code.)

BUG=685195
Review-Url: https://codereview.chromium.org/2654873004
Cr-Commit-Position: refs/heads/master@{#447952}
Committed: https://chromium.googlesource.com/chromium/src/+/9071e0ea6e201c38826160e2c397327a9681473e

[iclelland, 2017-01-24 20:19:31]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:20:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-01-24 20:37:48]

iclelland@chromium.org changed reviewers:
+ raymes@chromium.org

[iclelland, 2017-01-24 20:37:48]

+r raymes -- Second part (of several) splitting up the monster CL in
https://codereview.chromium.org/2636843003/ into manageable parts.

[commit-bot: I haz the power, 2017-01-24 20:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:50:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2017-01-25 01:00:42]

lgtm - the only thing I'm not sure about is what should live in content/child vs
content/renderer. I'm assuming you know better than me and that content/ OWNERs
will chime in anyway :)

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
File content/child/feature_policy/feature_policy_platform.cc (right):

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
content/child/feature_policy/feature_policy_platform.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
nit 2017

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
File content/child/feature_policy/feature_policy_platform.h (right):

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
content/child/feature_policy/feature_policy_platform.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
File content/common/feature_policy/feature_policy.cc (right):

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
File content/common/feature_policy/feature_policy.h (right):

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.h:33: using
ParsedFeaturePolicyHeader = std::vector<ParsedFeaturePolicyDeclaration>;
nit: newline before

[iclelland, 2017-01-25 03:23:50]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 03:24:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-01-25 03:28:38]

> lgtm - the only thing I'm not sure about is what should live in content/child
vs
content/renderer. I'm assuming you know better than me and that content/ OWNERs
will chime in anyway :)

I'm pretty sure that we eventually want this to be available to workers, so it
makes sense that the code that deals with Web* classes be available in
content/child. (Putting that code into content/common raised too many dependency
issues, and we don't need it for the browser process anyway)

The rest of the code goes into content/common so that we can use the content/
classes in the browser. (That's the next CL in the chain, as soon as I upload
that)

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
File content/child/feature_policy/feature_policy_platform.cc (right):

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
content/child/feature_policy/feature_policy_platform.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/01/25 01:00:42, raymes wrote:
> nit 2017

Done.

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
File content/child/feature_policy/feature_policy_platform.h (right):

https://codereview.chromium.org/2654873004/diff/20001/content/child/feature_p...
content/child/feature_policy/feature_policy_platform.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/01/25 01:00:42, raymes wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
File content/common/feature_policy/feature_policy.cc (right):

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.cc:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/01/25 01:00:42, raymes wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
File content/common/feature_policy/feature_policy.h (right):

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/01/25 01:00:42, raymes wrote:
> nit: 2017

Done.

[commit-bot: I haz the power, 2017-01-25 05:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 05:21:57]

Dry run: This issue passed the CQ dry run.

[iclelland, 2017-01-25 14:50:53]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 14:51:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-01-25 14:58:04]

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
File content/common/feature_policy/feature_policy.h (right):

https://codereview.chromium.org/2654873004/diff/20001/content/common/feature_...
content/common/feature_policy/feature_policy.h:33: using
ParsedFeaturePolicyHeader = std::vector<ParsedFeaturePolicyDeclaration>;
On 2017/01/25 01:00:42, raymes wrote:
> nit: newline before

Done.

[iclelland, 2017-01-25 15:25:41]

Description was changed from

==========
Move content-side Feature Policy code into content/{common,child}/feature_policy

BUG=
==========

to

==========
Move content-side Feature Policy code into content/{common,child}/feature_policy

This is part 2 of 5 in the effort to move the FeaturePolicy implementation
into the content layer, which will facilitate use of the framework for browser-
based policy decisions.

See the other CLs in this series:
[1/5] https://codereview.chromium.org/2648423002/ (Rename classes)
[2/5] (This CL)                                   (Centralize content-side code)
[3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in
browser)
[4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink)
[5/5] https://codereview.chromium.org/2656533004/ (Remove unused blink code.)

BUG=685195
==========

[commit-bot: I haz the power, 2017-01-25 16:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:39:32]

Dry run: This issue passed the CQ dry run.

[iclelland, 2017-01-27 20:14:58]

iclelland@chromium.org changed reviewers:
+ pfeldman@chromium.org

[iclelland, 2017-01-27 20:14:59]

+r pfeldman, can you PTAL? Thanks!

[pfeldman, 2017-01-27 22:08:52]

lgtm

[iclelland, 2017-02-03 04:33:22]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2017-02-03 04:33:22]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2654873004/#ps60001
(title: "Fix missed nit")

[commit-bot: I haz the power, 2017-02-03 04:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 06:36:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486096402143870,
"parent_rev": "97a781d90401a977e45add57359fe5df435ee317", "commit_rev":
"9071e0ea6e201c38826160e2c397327a9681473e"}

[commit-bot: I haz the power, 2017-02-03 06:36:56]

Description was changed from

==========
Move content-side Feature Policy code into content/{common,child}/feature_policy

This is part 2 of 5 in the effort to move the FeaturePolicy implementation
into the content layer, which will facilitate use of the framework for browser-
based policy decisions.

See the other CLs in this series:
[1/5] https://codereview.chromium.org/2648423002/ (Rename classes)
[2/5] (This CL)                                   (Centralize content-side code)
[3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in
browser)
[4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink)
[5/5] https://codereview.chromium.org/2656533004/ (Remove unused blink code.)

BUG=685195
==========

to

==========
Move content-side Feature Policy code into content/{common,child}/feature_policy

This is part 2 of 5 in the effort to move the FeaturePolicy implementation
into the content layer, which will facilitate use of the framework for browser-
based policy decisions.

See the other CLs in this series:
[1/5] https://codereview.chromium.org/2648423002/ (Rename classes)
[2/5] (This CL)                                   (Centralize content-side code)
[3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in
browser)
[4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink)
[5/5] https://codereview.chromium.org/2656533004/ (Remove unused blink code.)

BUG=685195

Review-Url: https://codereview.chromium.org/2654873004
Cr-Commit-Position: refs/heads/master@{#447952}
Committed:
https://chromium.googlesource.com/chromium/src/+/9071e0ea6e201c38826160e2c397...
==========

[commit-bot: I haz the power, 2017-02-03 06:36:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9071e0ea6e201c38826160e2c397...