The great shader refactor: Finish merging YUV shaders

The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2647743002
Cr-Commit-Position: refs/heads/master@{#444857}
Committed: https://chromium.googlesource.com/chromium/src/+/44f12b27985c6465c564b4841f0cd05833cdb5c4

[ccameron, 2017-01-19 20:51:43]

Description was changed from

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
==========

to

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-19 20:51:44]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 20:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 20:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 20:54:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[ccameron, 2017-01-19 21:05:23]

Description was changed from

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor, coda: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-19 21:05:24]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-01-19 21:06:17]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-19 21:06:40]

Description was changed from

==========
The great shader refactor, coda: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-19 21:07:16]

ptal

I think that this is the last step of the massive refactor.

[enne (OOO), 2017-01-19 21:36:46]

lgtm

[ccameron, 2017-01-19 21:42:47]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-01-19 21:43:49]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:14:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484862229110970,
"parent_rev": "56508cd35b92846ad5f61bc8115c5186cd1cb152", "commit_rev":
"44f12b27985c6465c564b4841f0cd05833cdb5c4"}

[commit-bot: I haz the power, 2017-01-19 22:14:56]

Description was changed from

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Finish merging YUV shaders

Get rid of the remaining odd-one-out behavior for YUV shaders with
color conversion.

Move the YUV-to-RGB math in GLRenderer to a helper function and point
out that it is duplicated code.

Get dir of unnecessarily cached uniform locations.

Make decisions based on behavior, not whether or not uniform locations
are not -1.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2647743002
Cr-Commit-Position: refs/heads/master@{#444857}
Committed:
https://chromium.googlesource.com/chromium/src/+/44f12b27985c6465c564b4841f0c...
==========

[commit-bot: I haz the power, 2017-01-19 22:14:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44f12b27985c6465c564b4841f0c...