[wasm] Turn on trap-if by default.

[wasm] Turn on trap-if by default.

This CL turns on trap-if by default, and it changes the tests so that
traps in the cctests are also tested without trap-if.

R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2647323002
Cr-Original-Commit-Position: refs/heads/master@{#42603}
Committed: https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bba0fef
Review-Url: https://codereview.chromium.org/2647323002
Cr-Commit-Position: refs/heads/master@{#42688}
Committed: https://chromium.googlesource.com/v8/v8/+/98fa962e5f342878109c26fd7190573082ac3abe

[ahaas, 2017-01-23 12:21:33]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 12:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 12:22:05]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21414)

[titzer, 2017-01-23 12:25:44]

LGTM, let's rock this boat!

[Clemens Hammacher, 2017-01-23 12:26:43]

Woohoo, trap-if is there! Let's hope that it sticks.
lgtm

[ahaas, 2017-01-23 15:35:37]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2017-01-23 15:35:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 15:59:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485185737365280, "parent_rev":
"87d7bb40d68a09a5197192358fb300645f9e3202", "commit_rev":
"01c87ebe70fb569205432597f3105c708bba0fef"}

[commit-bot: I haz the power, 2017-01-23 15:59:49]

Description was changed from

==========
[wasm] Turn on trap-if by default.

This CL turns on trap-if by default, and it changes the tests so that
traps in the cctests are also tested without trap-if.

R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org
==========

to

==========
[wasm] Turn on trap-if by default.

This CL turns on trap-if by default, and it changes the tests so that
traps in the cctests are also tested without trap-if.

R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2647323002
Cr-Commit-Position: refs/heads/master@{#42603}
Committed:
https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bb...
==========

[commit-bot: I haz the power, 2017-01-23 15:59:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bb...

[Clemens Hammacher, 2017-01-23 16:23:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2645403005/ by clemensh@chromium.org.

The reason for reverting is: gc-stress failures.

[ahaas, 2017-01-26 10:51:23]

On 2017/01/23 at 16:23:14, clemensh wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2645403005/ by clemensh@chromium.org.
> 
> The reason for reverting is: gc-stress failures.

PTAL, the problem with the gc-stress tests was fixed in
https://codereview.chromium.org/2655243002.

[titzer, 2017-01-26 10:52:59]

On 2017/01/26 10:51:23, ahaas wrote:
> On 2017/01/23 at 16:23:14, clemensh wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2645403005/ by mailto:clemensh@chromium.org.
> > 
> > The reason for reverting is: gc-stress failures.
> 
> PTAL, the problem with the gc-stress tests was fixed in
> https://codereview.chromium.org/2655243002.

lgtm, let's launch this rocket!

[ahaas, 2017-01-26 10:53:46]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2017-01-26 10:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 11:29:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485428026931430, "parent_rev":
"967c1a4ed7683665d780a811ca5bd942cb1a1d99", "commit_rev":
"98fa962e5f342878109c26fd7190573082ac3abe"}

[commit-bot: I haz the power, 2017-01-26 11:29:29]

Description was changed from

==========
[wasm] Turn on trap-if by default.

This CL turns on trap-if by default, and it changes the tests so that
traps in the cctests are also tested without trap-if.

R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2647323002
Cr-Commit-Position: refs/heads/master@{#42603}
Committed:
https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bb...
==========

to

==========
[wasm] Turn on trap-if by default.

This CL turns on trap-if by default, and it changes the tests so that
traps in the cctests are also tested without trap-if.

R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2647323002
Cr-Original-Commit-Position: refs/heads/master@{#42603}
Committed:
https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bb...
Review-Url: https://codereview.chromium.org/2647323002
Cr-Commit-Position: refs/heads/master@{#42688}
Committed:
https://chromium.googlesource.com/v8/v8/+/98fa962e5f342878109c26fd7190573082a...
==========

[commit-bot: I haz the power, 2017-01-26 11:29:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/98fa962e5f342878109c26fd7190573082a...