Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2645403005: Revert of [wasm] Turn on trap-if by default. (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson, ahaas
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Turn on trap-if by default. (patchset #1 id:1 of https://codereview.chromium.org/2647323002/ ) Reason for revert: gc-stress failures Original issue's description: > [wasm] Turn on trap-if by default. > > This CL turns on trap-if by default, and it changes the tests so that > traps in the cctests are also tested without trap-if. > > R=titzer@chromium.org, clemensh@chromium.org, bradnelson@chromium.org > > Review-Url: https://codereview.chromium.org/2647323002 > Cr-Commit-Position: refs/heads/master@{#42603} > Committed: https://chromium.googlesource.com/v8/v8/+/01c87ebe70fb569205432597f3105c708bba0fef TBR=bradnelson@chromium.org,titzer@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2645403005 Cr-Commit-Position: refs/heads/master@{#42604} Committed: https://chromium.googlesource.com/v8/v8/+/5582100308ba104837951f4f9340361270a9cfc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Clemens Hammacher
Created Revert of [wasm] Turn on trap-if by default.
3 years, 11 months ago (2017-01-23 16:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645403005/1
3 years, 11 months ago (2017-01-23 16:23:20 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:23:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5582100308ba104837951f4f9340361270a...

Powered by Google App Engine
This is Rietveld 408576698