Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2655243002: [wasm] For trap-if, always record a reference map on ia32. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] For trap-if, always record a reference map on ia32. The reference map was only recorded when a frame was entered for the runtime call, but it is also needed when the frame already exists. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2655243002 Cr-Commit-Position: refs/heads/master@{#42687} Committed: https://chromium.googlesource.com/v8/v8/+/967c1a4ed7683665d780a811ca5bd942cb1a1d99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 11 months ago (2017-01-26 09:16:39 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-26 10:43:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655243002/1
3 years, 11 months ago (2017-01-26 10:48:30 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 10:50:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/967c1a4ed7683665d780a811ca5bd942cb1...

Powered by Google App Engine
This is Rietveld 408576698