Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2647293003: Merge to M-56 (branch 2924) Use the correct profile for shelf prefs. (Closed)

Created:
3 years, 11 months ago by msw
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to M-56 (branch 2924) Use the correct profile for shelf prefs. Used the attached profile; not the active profile. Regressed in: https://codereview.chromium.org/2391253004 BUG=675599 TEST=Multi-login cros users get correct shelf prefs. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2613303003 Cr-Commit-Position: refs/heads/master@{#442045} (cherry picked from commit 913296ee74616a4589b5fea9c5873ead36e0e321) Review-Url: https://codereview.chromium.org/2647293003 . Cr-Commit-Position: refs/branch-heads/2924@{#841} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/78cf9e379414559004f8446a83d41ad78fab71dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
msw
Committed patchset #1 (id:1) manually as 78cf9e379414559004f8446a83d41ad78fab71dd.
3 years, 11 months ago (2017-01-23 18:02:34 UTC) #2
James Cook
3 years, 11 months ago (2017-01-23 18:15:47 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698