Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2613303003: Use the correct profile for shelf prefs. (Closed)

Created:
3 years, 11 months ago by msw
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct profile for shelf prefs. Used the attached profile; not the active profile. Regressed in: https://codereview.chromium.org/2391253004 BUG=675599 TEST=Multi-login cros users get correct shelf prefs. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2613303003 Cr-Commit-Position: refs/heads/master@{#442045} Committed: https://chromium.googlesource.com/chromium/src/+/913296ee74616a4589b5fea9c5873ead36e0e321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
msw
Hey James, please take a look; thanks!
3 years, 11 months ago (2017-01-06 20:24:47 UTC) #3
James Cook
LGTM
3 years, 11 months ago (2017-01-06 20:34:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613303003/1
3 years, 11 months ago (2017-01-06 20:53:58 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 21:00:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/913296ee74616a4589b5fea9c587...

Powered by Google App Engine
This is Rietveld 408576698