Use mojo Shelf interfaces for both mash and classic ash.

Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org

Committed: https://crrev.com/49cfb8939b817e91b0e6f6aa0a2bdd85fb8529a6
Cr-Commit-Position: refs/heads/master@{#424455}

[msw, 2016-10-07 00:58:06]

Description was changed from

==========
Use mojo ShelfController interface for both mash and classic ash.

BUG=557406
==========

to

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

[msw, 2016-10-07 00:58:06]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-10-07 00:59:29]

Hey Scott, please take a look; thanks!

[msw, 2016-10-07 00:59:34]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 00:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 01:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 01:15:05]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[msw, 2016-10-07 01:29:04]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 01:29:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 02:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:24:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-07 16:10:18]

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
File ash/common/shelf/shelf_controller.cc (left):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
ash/common/shelf/shelf_controller.cc:196: void
ShelfDelegateMus::OnShelfVisibilityStateChanged(WmShelf* shelf) {}
How come OnShelfAutoHideStateChanged and OnShelfVisibilityStateChanged are no
longer needed?

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
File ash/common/shelf/shelf_controller.h (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
ash/common/shelf/shelf_controller.h:22: // Used by chrome to observe and manage
the per-display ash shelf instances.
This comment is confusing as it implies this code is created by chrome, but that
isn't the case.

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/wm_sh...
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/wm_sh...
ash/common/shelf/wm_shelf.cc:31: bool WmShelf::ShelfAlignmentAllowed() {
optional: rename to CanChangeShelfAlignment().

https://codereview.chromium.org/2391253004/diff/150001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/wm_shell.cc...
ash/common/wm_shell.cc:207: shelf_controller_(new ShelfController),  // Model
needed by ShelfDelegate.
MakeUnique?

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_manifest_overlay.json (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_manifest_overlay.json:17:
"ash::mojom::ShelfController",
Don't you also need to update ash/mus/manifest.json?

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:32:
ChromeLauncherController::ChromeLauncherController() : observer_binding_(this) {
Initialize profile_ to null?

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:124:
launcher_controller_helper_.reset(new LauncherControllerHelper(profile_));
MakeUnique

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:134: new
extensions::ExtensionAppIconLoader(
MakeUnique

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:56: private
AppIconLoaderDelegate {
private->public

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:67: static void
set_instance(ChromeLauncherController* instance) {
optional/future: nuke this and set in constructor?

[msw, 2016-10-07 22:18:20]

Description was changed from

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

to

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

[msw, 2016-10-07 22:30:23]

Description was changed from

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

to

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

[msw, 2016-10-07 22:45:58]

Hey Scott, please take another look; thanks!
I'm investigating a few more test failures/crashes :(

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
File ash/common/shelf/shelf_controller.cc (left):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
ash/common/shelf/shelf_controller.cc:196: void
ShelfDelegateMus::OnShelfVisibilityStateChanged(WmShelf* shelf) {}
On 2016/10/07 16:10:17, sky wrote:
> How come OnShelfAutoHideStateChanged and OnShelfVisibilityStateChanged are no
> longer needed?

All implementations are empty / no-op, ditto for OnShelfDestroyed:
  https://cs.chromium.org/search/?q=OnShelfAutoHideStateChanged
  https://cs.chromium.org/search/?q=OnShelfVisibilityStateChanged
  https://cs.chromium.org/search/?q=OnShelfDestroyed
They can be added back later if they're ever needed.

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
File ash/common/shelf/shelf_controller.h (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/shelf...
ash/common/shelf/shelf_controller.h:22: // Used by chrome to observe and manage
the per-display ash shelf instances.
On 2016/10/07 16:10:17, sky wrote:
> This comment is confusing as it implies this code is created by chrome, but
that
> isn't the case.

Done.

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/wm_sh...
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/shelf/wm_sh...
ash/common/shelf/wm_shelf.cc:31: bool WmShelf::ShelfAlignmentAllowed() {
On 2016/10/07 16:10:17, sky wrote:
> optional: rename to CanChangeShelfAlignment().

Done.

https://codereview.chromium.org/2391253004/diff/150001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/ash/common/wm_shell.cc...
ash/common/wm_shell.cc:207: shelf_controller_(new ShelfController),  // Model
needed by ShelfDelegate.
On 2016/10/07 16:10:17, sky wrote:
> MakeUnique?

Done.

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_manifest_overlay.json (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_manifest_overlay.json:17:
"ash::mojom::ShelfController",
On 2016/10/07 16:10:17, sky wrote:
> Don't you also need to update ash/mus/manifest.json?

Done, made mash->chrome list classes, not required interfaces:
https://cs.chromium.org/chromium/src/chrome/app/mash/chrome_mash_content_brow...

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:32:
ChromeLauncherController::ChromeLauncherController() : observer_binding_(this) {
On 2016/10/07 16:10:18, sky wrote:
> Initialize profile_ to null?

Done in header.

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:124:
launcher_controller_helper_.reset(new LauncherControllerHelper(profile_));
On 2016/10/07 16:10:17, sky wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:134: new
extensions::ExtensionAppIconLoader(
On 2016/10/07 16:10:18, sky wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:56: private
AppIconLoaderDelegate {
On 2016/10/07 16:10:18, sky wrote:
> private->public

Done.

https://codereview.chromium.org/2391253004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:67: static void
set_instance(ChromeLauncherController* instance) {
On 2016/10/07 16:10:18, sky wrote:
> optional/future: nuke this and set in constructor?

Done. Also removed the CreateInstance static methods and MashInit(), etc.

[sky, 2016-10-07 22:59:38]

https://codereview.chromium.org/2391253004/diff/170001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/2391253004/diff/170001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_shell_delegate.cc:437: shelf_delegate_ = new
ChromeLauncherControllerImpl(nullptr, model);
Does this leak?

[msw, 2016-10-07 23:13:01]

https://codereview.chromium.org/2391253004/diff/170001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/2391253004/diff/170001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_shell_delegate.cc:437: shelf_delegate_ = new
ChromeLauncherControllerImpl(nullptr, model);
On 2016/10/07 22:59:37, sky wrote:
> Does this leak?

No, it's owned by the unique_ptr WmShell::shelf_delegate_:
  https://cs.chromium.org/chromium/src/ash/common/wm_shell.cc?l=134

[sky, 2016-10-07 23:26:25]

This looks good, but as discussed it sounds like you need to make a couple of
changes. Let me know when you straighten out the test issues and I'll take
another look.

[James Cook, 2016-10-10 17:18:12]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-10-10 17:18:14]

https://codereview.chromium.org/2391253004/diff/210001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2391253004/diff/210001/ash/common/wm_shell.h#...
ash/common/wm_shell.h:155: ShelfModel* shelf_model() { return
shelf_controller_->model(); }
drive by: I would implement this in the .cc file. The style guide does not
require hacker_style() functions to be inline, and shelf_controller.h includes
generated mojo headers that significantly slow down build time. Given that
shell.h is widely included I think it would be worth de-inlining this.

[msw, 2016-10-10 20:52:49]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:50:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-10-11 00:30:57]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-11 00:44:06]

Please take another look thanks, I think I resolved the last test issues.

https://codereview.chromium.org/2391253004/diff/210001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2391253004/diff/210001/ash/common/wm_shell.h#...
ash/common/wm_shell.h:155: ShelfModel* shelf_model() { return
shelf_controller_->model(); }
On 2016/10/10 17:18:13, James Cook wrote:
> drive by: I would implement this in the .cc file. The style guide does not
> require hacker_style() functions to be inline, and shelf_controller.h includes
> generated mojo headers that significantly slow down build time. Given that
> shell.h is widely included I think it would be worth de-inlining this.

Done.

[commit-bot: I haz the power, 2016-10-11 02:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:29:45]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-11 02:40:37]

LGTM

https://codereview.chromium.org/2391253004/diff/250001/ash/display/window_tre...
File ash/display/window_tree_host_manager.cc (right):

https://codereview.chromium.org/2391253004/diff/250001/ash/display/window_tre...
ash/display/window_tree_host_manager.cc:340: if
(window_tree_hosts_.count(display_id) == 0)
use find and a conditional to avoid the double lookup.

https://codereview.chromium.org/2391253004/diff/250001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2391253004/diff/250001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:68: static void
set_instance_for_test(ChromeLauncherController* instance) {
optional: I'm not a fan of polluting public API with fortest functions. Use a
friend.

[msw, 2016-10-11 15:38:00]

https://codereview.chromium.org/2391253004/diff/250001/ash/display/window_tre...
File ash/display/window_tree_host_manager.cc (right):

https://codereview.chromium.org/2391253004/diff/250001/ash/display/window_tre...
ash/display/window_tree_host_manager.cc:340: if
(window_tree_hosts_.count(display_id) == 0)
On 2016/10/11 02:40:37, sky wrote:
> use find and a conditional to avoid the double lookup.

Done.

https://codereview.chromium.org/2391253004/diff/250001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2391253004/diff/250001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:68: static void
set_instance_for_test(ChromeLauncherController* instance) {
On 2016/10/11 02:40:37, sky wrote:
> optional: I'm not a fan of polluting public API with fortest functions. Use a
> friend.

Added a TODO; it's a temporary workaround for crbug.com/654622.

[msw, 2016-10-11 15:38:06]

The CQ bit was checked by msw@chromium.org

[msw, 2016-10-11 15:38:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2391253004/#ps270001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-10-11 15:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:59:02]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msw, 2016-10-11 16:04:03]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:46:40]

Description was changed from

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

to

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-10-11 16:46:42]

Committed patchset #15 (id:270001)

[commit-bot: I haz the power, 2016-10-11 16:49:14]

Description was changed from

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org
==========

to

==========
Use mojo Shelf interfaces for both mash and classic ash.

( Similar to https://codereview.chromium.org/2381753002 )

Add a mojom::ShelfController implementation in ash.
Migrate some functionality from ShelfDelegateMus.
(pinning, id mapping, etc. are unused at the moment)
Move some chrome-side shelf init checking to ash.

Move ownership of the ShelfModel to ShelfController.
Move ShelfAlignmentAllowed from ShelfWidget to WmShelf.
Remove unused ShelfDelegate::OnShelf* functions.

Make ChromeLauncherController a mojom::ShelfObserver.
Consolidate functionality from mash and classic ash.
New CLC functionality replaces ChromeMashShelfController.
Remove CLC::set_instance and CreateInstance helpers.
Convert mash manifest usage from interfaces to classes.
Inline chrome::InitializeMash.

TODO: Make ChromeLauncherController work better in Mash.

BUG=557406
TEST=No Chrome OS shelf alignment/auto-hide regressions.
R=sky@chromium.org

Committed: https://crrev.com/49cfb8939b817e91b0e6f6aa0a2bdd85fb8529a6
Cr-Commit-Position: refs/heads/master@{#424455}
==========

[commit-bot: I haz the power, 2016-10-11 16:49:15]

Patchset 15 (id:??) landed as
https://crrev.com/49cfb8939b817e91b0e6f6aa0a2bdd85fb8529a6
Cr-Commit-Position: refs/heads/master@{#424455}