Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 26471007: QUIC: don't ignore SetKey and SetNoncePrefix return values. (Closed)

Created:
7 years, 2 months ago by ramant (doing other things)
Modified:
7 years, 2 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl
Visibility:
Public.

Description

QUIC: don't ignore SetKey and SetNoncePrefix return values. This change causes failures to set the AES-GCM key and nonce to bubble up and kill the connection. I don't think that we've had any failures, but you never know and it would be bad to, say, start transmitting plaintext or something because we didn't notice that we failed to set a key. (The OpenSSL AEAD API doesn't actually let that happen: it zeros the output buffer on any failure, but things might change in the future.) (This is a follow up from a previous CL which altered our AES-128-GCM implementation.) Merge internal change: 53742674 R=rch@chromium.org, wtc@chromium.org

Patch Set 1 #

Patch Set 2 : Merging with tip #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M net/quic/crypto/crypto_handshake.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 3 chunks +20 lines, -10 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +1 line, -1 line 1 comment Download
M net/quic/crypto/crypto_utils.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
7 years, 2 months ago (2013-10-08 21:12:56 UTC) #1
ramant (doing other things)
7 years, 2 months ago (2013-10-08 21:13:17 UTC) #2
Ryan Hamilton
lgtm
7 years, 2 months ago (2013-10-08 22:59:37 UTC) #3
wtc
7 years, 2 months ago (2013-10-09 23:01:28 UTC) #4
Message was sent while issue was closed.
Patch set 2 LGTM.

https://codereview.chromium.org/26471007/diff/4001/net/quic/crypto/crypto_uti...
File net/quic/crypto/crypto_utils.h (right):

https://codereview.chromium.org/26471007/diff/4001/net/quic/crypto/crypto_uti...
net/quic/crypto/crypto_utils.h:58: static bool DeriveKeys(base::StringPiece
premaster_secret,

Nit: document the return value.

Powered by Google App Engine
This is Rietveld 408576698