QUIC: don't ignore SetKey and SetNoncePrefix return values.

net/quic/crypto/crypto_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/crypto_utils.h"
 
 #include "crypto/hkdf.h"
 #include "net/base/net_util.h"
 #include "net/quic/crypto/crypto_handshake.h"
 #include "net/quic/crypto/crypto_protocol.h"
@@ skipping 59 matching lines @@
   }
 
   // Erase the trailing dots.
   if (host_end != host.length()) {
     host.erase(host_end, host.length() - host_end);
   }
   return host;
 }
 
 // static
-void CryptoUtils::DeriveKeys(StringPiece premaster_secret,
+bool CryptoUtils::DeriveKeys(StringPiece premaster_secret,
                              QuicTag aead,
                              StringPiece client_nonce,
                              StringPiece server_nonce,
                              const string& hkdf_input,
                              Perspective perspective,
                              CrypterPair* out) {
   out->encrypter.reset(QuicEncrypter::Create(aead));
   out->decrypter.reset(QuicDecrypter::Create(aead));
   size_t key_bytes = out->encrypter->GetKeySize();
   size_t nonce_prefix_bytes = out->encrypter->GetNoncePrefixSize();
 
   StringPiece nonce = client_nonce;
   string nonce_storage;
   if (!server_nonce.empty()) {
     nonce_storage = client_nonce.as_string() + server_nonce.as_string();
     nonce = nonce_storage;
   }
 
   crypto::HKDF hkdf(premaster_secret, nonce, hkdf_input, key_bytes,
                     nonce_prefix_bytes);
   if (perspective == SERVER) {
-    out->encrypter->SetKey(hkdf.server_write_key());
-    out->encrypter->SetNoncePrefix(hkdf.server_write_iv());
-    out->decrypter->SetKey(hkdf.client_write_key());
-    out->decrypter->SetNoncePrefix(hkdf.client_write_iv());
+    if (!out->encrypter->SetKey(hkdf.server_write_key()) ||
+        !out->encrypter->SetNoncePrefix(hkdf.server_write_iv()) ||
+        !out->decrypter->SetKey(hkdf.client_write_key()) ||
+        !out->decrypter->SetNoncePrefix(hkdf.client_write_iv())) {
+      return false;
+    }
   } else {
-    out->encrypter->SetKey(hkdf.client_write_key());
-    out->encrypter->SetNoncePrefix(hkdf.client_write_iv());
-    out->decrypter->SetKey(hkdf.server_write_key());
-    out->decrypter->SetNoncePrefix(hkdf.server_write_iv());
+    if (!out->encrypter->SetKey(hkdf.client_write_key()) ||
+        !out->encrypter->SetNoncePrefix(hkdf.client_write_iv()) ||
+        !out->decrypter->SetKey(hkdf.server_write_key()) ||
+        !out->decrypter->SetNoncePrefix(hkdf.server_write_iv())) {
+      return false;
+    }
   }
+
+  return true;
 }
 
 }  // namespace net