Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: net/quic/quic_utils.cc

Issue 26471007: QUIC: don't ignore SetKey and SetNoncePrefix return values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merging with tip Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« net/quic/crypto/crypto_utils.h ('K') | « net/quic/quic_protocol.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_utils.h" 5 #include "net/quic/quic_utils.h"
6 6
7 #include <ctype.h> 7 #include <ctype.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/port.h" 10 #include "base/port.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 RETURN_STRING_LITERAL(QUIC_CONNECTION_TIMED_OUT); 191 RETURN_STRING_LITERAL(QUIC_CONNECTION_TIMED_OUT);
192 RETURN_STRING_LITERAL(QUIC_ERROR_MIGRATING_ADDRESS); 192 RETURN_STRING_LITERAL(QUIC_ERROR_MIGRATING_ADDRESS);
193 RETURN_STRING_LITERAL(QUIC_PACKET_WRITE_ERROR); 193 RETURN_STRING_LITERAL(QUIC_PACKET_WRITE_ERROR);
194 RETURN_STRING_LITERAL(QUIC_PACKET_READ_ERROR); 194 RETURN_STRING_LITERAL(QUIC_PACKET_READ_ERROR);
195 RETURN_STRING_LITERAL(QUIC_INVALID_STREAM_FRAME); 195 RETURN_STRING_LITERAL(QUIC_INVALID_STREAM_FRAME);
196 RETURN_STRING_LITERAL(QUIC_PROOF_INVALID); 196 RETURN_STRING_LITERAL(QUIC_PROOF_INVALID);
197 RETURN_STRING_LITERAL(QUIC_CRYPTO_DUPLICATE_TAG); 197 RETURN_STRING_LITERAL(QUIC_CRYPTO_DUPLICATE_TAG);
198 RETURN_STRING_LITERAL(QUIC_CRYPTO_ENCRYPTION_LEVEL_INCORRECT); 198 RETURN_STRING_LITERAL(QUIC_CRYPTO_ENCRYPTION_LEVEL_INCORRECT);
199 RETURN_STRING_LITERAL(QUIC_CRYPTO_SERVER_CONFIG_EXPIRED); 199 RETURN_STRING_LITERAL(QUIC_CRYPTO_SERVER_CONFIG_EXPIRED);
200 RETURN_STRING_LITERAL(QUIC_INVALID_CHANNEL_ID_SIGNATURE); 200 RETURN_STRING_LITERAL(QUIC_INVALID_CHANNEL_ID_SIGNATURE);
201 RETURN_STRING_LITERAL(QUIC_CRYPTO_SYMMETRIC_KEY_SETUP_FAILED);
201 RETURN_STRING_LITERAL(QUIC_LAST_ERROR); 202 RETURN_STRING_LITERAL(QUIC_LAST_ERROR);
202 // Intentionally have no default case, so we'll break the build 203 // Intentionally have no default case, so we'll break the build
203 // if we add errors and don't put them here. 204 // if we add errors and don't put them here.
204 } 205 }
205 // Return a default value so that we return this when |error| doesn't match 206 // Return a default value so that we return this when |error| doesn't match
206 // any of the QuicErrorCodes. This can happen when the ConnectionClose 207 // any of the QuicErrorCodes. This can happen when the ConnectionClose
207 // frame sent by the peer (attacker) has invalid error code. 208 // frame sent by the peer (attacker) has invalid error code.
208 return "INVALID_ERROR_CODE"; 209 return "INVALID_ERROR_CODE";
209 } 210 }
210 211
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 271
271 bytes_remaining -= line_bytes; 272 bytes_remaining -= line_bytes;
272 offset += line_bytes; 273 offset += line_bytes;
273 p += line_bytes; 274 p += line_bytes;
274 s += '\n'; 275 s += '\n';
275 } 276 }
276 return s; 277 return s;
277 } 278 }
278 279
279 } // namespace net 280 } // namespace net
OLDNEW
« net/quic/crypto/crypto_utils.h ('K') | « net/quic/quic_protocol.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698