Move property tree debugging code to platform/graphics/paint/ (try #2)

Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2647063002
Cr-Commit-Position: refs/heads/master@{#445197}
Committed: https://chromium.googlesource.com/chromium/src/+/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b

[chrishtr, 2017-01-20 17:18:53]

Description was changed from

==========
none


Revert "Revert of Move property tree debugging code to platform/graphics/paint/.
(patchset #8 id:140001 of https://codereview.chromium.org/2638763003/ )"

This reverts commit 105f592cb030b5e0b210e15a74a3341ea24e4e75.

BUG=
==========

to

==========
none


Revert "Revert of Move property tree debugging code to platform/graphics/paint/.
(patchset #8 id:140001 of https://codereview.chromium.org/2638763003/ )"

This reverts commit 105f592cb030b5e0b210e15a74a3341ea24e4e75.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-20 17:21:01]

Description was changed from

==========
none


Revert "Revert of Move property tree debugging code to platform/graphics/paint/.
(patchset #8 id:140001 of https://codereview.chromium.org/2638763003/ )"

This reverts commit 105f592cb030b5e0b210e15a74a3341ea24e4e75.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the
following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-20 17:21:10]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 17:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 17:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:42:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-01-20 17:47:12]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 17:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:08:37]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-01-20 22:10:06]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-01-20 22:11:51]

LGTM

[chrishtr, 2017-01-20 22:51:18]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:51:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:56:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484952678793160,
"parent_rev": "79c8fcfec38b8d2f59fa71c9a073717b37bb48ee", "commit_rev":
"cd60843ee27fdeeb53a6a9f236cf9de4eec5135b"}

[commit-bot: I haz the power, 2017-01-20 22:56:44]

Description was changed from

==========
Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the
following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the
following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2647063002
Cr-Commit-Position: refs/heads/master@{#445197}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd60843ee27fdeeb53a6a9f236cf...
==========

[commit-bot: I haz the power, 2017-01-20 22:56:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd60843ee27fdeeb53a6a9f236cf...

[Xianzhu, 2017-01-25 20:36:38]

A question about debugging with the functions returning Strings: How do you use
them in gdb?

I use:
(gdb) p treeState.transform()->toTreeString()

but the output looks not good:
$2 = "root 0x26f1bcbbc010 parent=(nil) transform=identity origin=0,0,0
flattensInheritedTransform=no renderingContextId=0 directCompositingReasons=none
compositorElementId=(0, 0)\n   0x26f1bcbbc1f0 parent=0x"...

I would like something like
(gdb) p showTreeString(treeState.transform())

which will print the whole string with '\n's not escaped.

[Xianzhu, 2017-01-25 20:37:34]

Description was changed from

==========
Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the
following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2647063002
Cr-Commit-Position: refs/heads/master@{#445197}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd60843ee27fdeeb53a6a9f236cf...
==========

to

==========
Move property tree debugging code to platform/graphics/paint/ (try #2)

This is a revert of https://codereview.chromium.org/2639143002, with the
following
fixes:

1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root"
2. Change #ifndef NDEBUG to #if DCHECK_IS_ON()

The former fixes the unittest. The latter ensures the test actually runs on the
bots, and increases debugging convenience.

BUG=682113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2647063002
Cr-Commit-Position: refs/heads/master@{#445197}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd60843ee27fdeeb53a6a9f236cf...
==========

[chrishtr, 2017-01-25 20:42:00]

On 2017/01/25 at 20:36:38, wangxianzhu wrote:
> A question about debugging with the functions returning Strings: How do you
use them in gdb?
> 
> I use:
> (gdb) p treeState.transform()->toTreeString()
> 
> but the output looks not good:
> $2 = "root 0x26f1bcbbc010 parent=(nil) transform=identity origin=0,0,0
flattensInheritedTransform=no renderingContextId=0 directCompositingReasons=none
compositorElementId=(0, 0)\n   0x26f1bcbbc1f0 parent=0x"...
> 
> I would like something like
> (gdb) p showTreeString(treeState.transform())
> 
> which will print the whole string with '\n's not escaped.

Walter suggested putting the following in ~/.gdbinit to prettyprint strings:

python
import sys
sys.path.insert(0, "/ssd2/git/chrome/src/third_party/WebKit/Tools/gdb/")
sys.path.insert(0, "/ssd2/git/chrome/src/tools/gdb/")
import webkit
import gdb_chrome
end

Not sure if it works.

[Xianzhu, 2017-01-25 20:54:06]

On 2017/01/25 20:42:00, chrishtr wrote:
> On 2017/01/25 at 20:36:38, wangxianzhu wrote:
> > A question about debugging with the functions returning Strings: How do you
> use them in gdb?
> > 
> > I use:
> > (gdb) p treeState.transform()->toTreeString()
> > 
> > but the output looks not good:
> > $2 = "root 0x26f1bcbbc010 parent=(nil) transform=identity origin=0,0,0
> flattensInheritedTransform=no renderingContextId=0
directCompositingReasons=none
> compositorElementId=(0, 0)\n   0x26f1bcbbc1f0 parent=0x"...
> > 
> > I would like something like
> > (gdb) p showTreeString(treeState.transform())
> > 
> > which will print the whole string with '\n's not escaped.
> 
> Walter suggested putting the following in ~/.gdbinit to prettyprint strings:
> 
> python
> import sys
> sys.path.insert(0, "/ssd2/git/chrome/src/third_party/WebKit/Tools/gdb/")
> sys.path.insert(0, "/ssd2/git/chrome/src/tools/gdb/")
> import webkit
> import gdb_chrome
> end
> 
> Not sure if it works.

I'm using them, but it is suitable to print short strings without formats
because it truncates long strings and escape line breaks to '\n's.
It seems that we still need functions like showXXXX() besides these toString()
functions for gdb.

[chrishtr, 2017-01-25 20:58:22]

On 2017/01/25 at 20:54:06, wangxianzhu wrote:
> On 2017/01/25 20:42:00, chrishtr wrote:
> > On 2017/01/25 at 20:36:38, wangxianzhu wrote:
> > > A question about debugging with the functions returning Strings: How do
you
> > use them in gdb?
> > > 
> > > I use:
> > > (gdb) p treeState.transform()->toTreeString()
> > > 
> > > but the output looks not good:
> > > $2 = "root 0x26f1bcbbc010 parent=(nil) transform=identity origin=0,0,0
> > flattensInheritedTransform=no renderingContextId=0
directCompositingReasons=none
> > compositorElementId=(0, 0)\n   0x26f1bcbbc1f0 parent=0x"...
> > > 
> > > I would like something like
> > > (gdb) p showTreeString(treeState.transform())
> > > 
> > > which will print the whole string with '\n's not escaped.
> > 
> > Walter suggested putting the following in ~/.gdbinit to prettyprint strings:
> > 
> > python
> > import sys
> > sys.path.insert(0, "/ssd2/git/chrome/src/third_party/WebKit/Tools/gdb/")
> > sys.path.insert(0, "/ssd2/git/chrome/src/tools/gdb/")
> > import webkit
> > import gdb_chrome
> > end
> > 
> > Not sure if it works.
> 
> I'm using them, but it is suitable to print short strings without formats
because it truncates long strings and escape line breaks to '\n's.
> It seems that we still need functions like showXXXX() besides these toString()
functions for gdb.

Oh, ok. Sure, makese sense to me.