Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2639143002: Revert of Move property tree debugging code to platform/graphics/paint/. (Closed)

Created:
3 years, 11 months ago by meade_UTC10
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move property tree debugging code to platform/graphics/paint/. (patchset #8 id:140001 of https://codereview.chromium.org/2638763003/ ) Reason for revert: Caused failures on 4 waterfall bots: WebKit Linux Trusty (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/550 WebKit Mac10.11 (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6955 WebKit Win x64 Builder (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/102661 WebKit Win7 (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8753 BUG=682113 Original issue's description: > Move property tree debugging code to platform/graphics/paint/. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2638763003 > Cr-Commit-Position: refs/heads/master@{#444190} > Committed: https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adce946ce06d3c0 TBR=wkorman@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2639143002 Cr-Commit-Position: refs/heads/master@{#444293} Committed: https://chromium.googlesource.com/chromium/src/+/105f592cb030b5e0b210e15a74a3341ea24e4e75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -115 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h View 3 chunks +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
meade_UTC10
Created Revert of Move property tree debugging code to platform/graphics/paint/.
3 years, 11 months ago (2017-01-18 06:04:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639143002/1
3 years, 11 months ago (2017-01-18 06:04:23 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 06:06:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/105f592cb030b5e0b210e15a74a3...

Powered by Google App Engine
This is Rietveld 408576698