Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

Issue 2647063002: Move property tree debugging code to platform/graphics/paint/ (try #2) (Closed)
Patch Set: none Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
index b545e276a3b159a8548014d219314d63c12ed1bc..3344e8a803e163b3680516340649cebc4851ce49 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
@@ -14,7 +14,7 @@
#include <iomanip>
#include <sstream>
-#ifndef NDEBUG
+#if DCHECK_IS_ON()
namespace blink {
namespace {
@@ -573,57 +573,6 @@ String scrollPropertyTreeAsString(const blink::FrameView& rootFrame) {
.treeAsString(rootFrame);
}
-String transformPaintPropertyPathAsString(
- const blink::TransformPaintPropertyNode* node) {
- return blink::PropertyTreePrinter<blink::TransformPaintPropertyNode>()
- .pathAsString(node);
-}
-
-String clipPaintPropertyPathAsString(const blink::ClipPaintPropertyNode* node) {
- return blink::PropertyTreePrinter<blink::ClipPaintPropertyNode>()
- .pathAsString(node);
-}
-
-String effectPaintPropertyPathAsString(
- const blink::EffectPaintPropertyNode* node) {
- return blink::PropertyTreePrinter<blink::EffectPaintPropertyNode>()
- .pathAsString(node);
-}
-
-String scrollPaintPropertyPathAsString(
- const blink::ScrollPaintPropertyNode* node) {
- return blink::PropertyTreePrinter<blink::ScrollPaintPropertyNode>()
- .pathAsString(node);
-}
-
-void showPaintPropertyPath(const blink::TransformPaintPropertyNode* node) {
- fprintf(stderr, "%s\n",
- transformPaintPropertyPathAsString(node).utf8().data());
-}
-
-void showPaintPropertyPath(const blink::ClipPaintPropertyNode* node) {
- fprintf(stderr, "%s\n", clipPaintPropertyPathAsString(node).utf8().data());
-}
-
-void showPaintPropertyPath(const blink::EffectPaintPropertyNode* node) {
- fprintf(stderr, "%s\n", effectPaintPropertyPathAsString(node).utf8().data());
-}
-
-void showPaintPropertyPath(const blink::ScrollPaintPropertyNode* node) {
- fprintf(stderr, "%s\n", scrollPaintPropertyPathAsString(node).utf8().data());
-}
-
-void showPropertyTreeState(const blink::PropertyTreeState& state) {
- fprintf(stderr, "%s\n", propertyTreeStateAsString(state).utf8().data());
-}
-
-String propertyTreeStateAsString(const blink::PropertyTreeState& state) {
- return transformPaintPropertyPathAsString(state.transform()) + "\n" +
- clipPaintPropertyPathAsString(state.clip()) + "\n" +
- effectPaintPropertyPathAsString(state.effect()) + "\n" +
- scrollPaintPropertyPathAsString(state.scroll());
-}
-
String paintPropertyTreeGraph(const blink::FrameView& frameView) {
blink::PaintPropertyTreeGraphBuilder builder;
StringBuilder stringBuilder;
@@ -631,4 +580,4 @@ String paintPropertyTreeGraph(const blink::FrameView& frameView) {
return stringBuilder.toString();
}
-#endif
+#endif // DCHECK_IS_ON()

Powered by Google App Engine
This is Rietveld 408576698