Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2646583002: Revert of Add DCHECK for duplicate layers with the same cc::ElementId. (Closed)

Created:
3 years, 11 months ago by jianli
Modified:
3 years, 11 months ago
Reviewers:
ajuma, skobes
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add DCHECK for duplicate layers with the same cc::ElementId. (patchset #2 id:20001 of https://codereview.chromium.org/2639103002/ ) Reason for revert: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6968 Original issue's description: > Add DCHECK for duplicate layers with the same cc::ElementId. > > BUG=673963 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2639103002 > Cr-Commit-Position: refs/heads/master@{#444407} > Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab627d8e23420a TBR=ajuma@chromium.org,skobes@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673963 Review-Url: https://codereview.chromium.org/2646583002 Cr-Commit-Position: refs/heads/master@{#444452} Committed: https://chromium.googlesource.com/chromium/src/+/bc1dbcfdf6fa0db6e78c6ac3af02b6d68e1e2c72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 chunk +6 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jianli
Created Revert of Add DCHECK for duplicate layers with the same cc::ElementId.
3 years, 11 months ago (2017-01-18 20:04:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646583002/1
3 years, 11 months ago (2017-01-18 20:04:29 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:09:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc1dbcfdf6fa0db6e78c6ac3af02...

Powered by Google App Engine
This is Rietveld 408576698