Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2639103002:
[Reland] Add DCHECK for duplicate layers with the same cc::ElementId. (Closed)
Description[Reland] Add DCHECK for duplicate layers with the same cc::ElementId.
This relands r444407 which was reverted in r444452.
BUG=673963
Review-Url: https://codereview.chromium.org/2639103002
Cr-Commit-Position: refs/heads/master@{#444407}
Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab627d8e23420a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2639103002
Cr-Commit-Position: refs/heads/master@{#444768}
Committed: https://chromium.googlesource.com/chromium/src/+/2409c02697954b6733938f95095423b93ef09e73
Patch Set 1 #
Total comments: 2
Patch Set 2 : address nit #Patch Set 3 : force layout tests for CQ dry run #Patch Set 4 : == ps2 #Messages
Total messages: 26 (17 generated)
Description was changed from ========== Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 ========== to ========== Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
skobes@chromium.org changed reviewers: + ajuma@chromium.org
lgtm https://codereview.chromium.org/2639103002/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/2639103002/diff/1/cc/trees/layer_tree_impl.cc... cc/trees/layer_tree_impl.cc:558: existing_layer != nullptr && existing_layer != layer; existing_layer && existing_layer != layer; might be more readable.
https://codereview.chromium.org/2639103002/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/2639103002/diff/1/cc/trees/layer_tree_impl.cc... cc/trees/layer_tree_impl.cc:558: existing_layer != nullptr && existing_layer != layer; On 2017/01/18 14:22:52, ajuma wrote: > existing_layer && existing_layer != layer; > might be more readable. Done.
The CQ bit was checked by skobes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org Link to the patchset: https://codereview.chromium.org/2639103002/#ps20001 (title: "address nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484756652589990,
"parent_rev": "eece208cecdcf7878dc69ed52d6f86cb306c21fd", "commit_rev":
"f547b3e1d559fd2abd8c9ed897ab627d8e23420a"}
Message was sent while issue was closed.
Description was changed from ========== Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2646583002/ by jianli@chromium.org. The reason for reverting is: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1....
Message was sent while issue was closed.
D'oh, this depends on http://crrev.com/2638223003.
Message was sent while issue was closed.
Description was changed from ========== Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ========== to ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ==========
Description was changed from ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ========== to ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. This relands r444407 which was reverted in r444452. BUG=673963 Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ==========
Description was changed from ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. This relands r444407 which was reverted in r444452. BUG=673963 Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... ========== to ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. This relands r444407 which was reverted in r444452. BUG=673963 Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by skobes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org Link to the patchset: https://codereview.chromium.org/2639103002/#ps60001 (title: "== ps2")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484841672115740,
"parent_rev": "630dcb3a25341206e66d3cae8cef4182273511dc", "commit_rev":
"2409c02697954b6733938f95095423b93ef09e73"}
Message was sent while issue was closed.
Description was changed from ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. This relands r444407 which was reverted in r444452. BUG=673963 Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== [Reland] Add DCHECK for duplicate layers with the same cc::ElementId. This relands r444407 which was reverted in r444452. BUG=673963 Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444407} Committed: https://chromium.googlesource.com/chromium/src/+/f547b3e1d559fd2abd8c9ed897ab... CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639103002 Cr-Commit-Position: refs/heads/master@{#444768} Committed: https://chromium.googlesource.com/chromium/src/+/2409c02697954b6733938f950954... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/2409c02697954b6733938f950954... |
