Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Side by Side Diff: cc/trees/layer_tree_impl.cc

Issue 2646583002: Revert of Add DCHECK for duplicate layers with the same cc::ElementId. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_impl.h" 5 #include "cc/trees/layer_tree_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 return Layer::INVALID_ID; 537 return Layer::INVALID_ID;
538 538
539 return iter->second; 539 return iter->second;
540 } 540 }
541 541
542 LayerImpl* LayerTreeImpl::LayerByElementId(ElementId element_id) const { 542 LayerImpl* LayerTreeImpl::LayerByElementId(ElementId element_id) const {
543 return LayerById(LayerIdByElementId(element_id)); 543 return LayerById(LayerIdByElementId(element_id));
544 } 544 }
545 545
546 void LayerTreeImpl::AddToElementMap(LayerImpl* layer) { 546 void LayerTreeImpl::AddToElementMap(LayerImpl* layer) {
547 ElementId element_id = layer->element_id(); 547 if (!layer->element_id())
548 if (!element_id)
549 return; 548 return;
550 549
551 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("compositor-worker"), 550 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("compositor-worker"),
552 "LayerTreeImpl::AddToElementMap", "element", 551 "LayerTreeImpl::AddToElementMap", "element",
553 element_id.AsValue().release(), "layer_id", layer->id()); 552 layer->element_id().AsValue().release(), "layer_id",
553 layer->id());
554 554
555 #if DCHECK_IS_ON() 555 element_layers_map_[layer->element_id()] = layer->id();
556 LayerImpl* existing_layer = LayerByElementId(element_id);
557 bool element_id_collision_detected =
558 existing_layer && existing_layer != layer;
559 DCHECK(!element_id_collision_detected);
560 #endif
561
562 element_layers_map_[element_id] = layer->id();
563 556
564 layer_tree_host_impl_->mutator_host()->RegisterElement( 557 layer_tree_host_impl_->mutator_host()->RegisterElement(
565 element_id, 558 layer->element_id(),
566 IsActiveTree() ? ElementListType::ACTIVE : ElementListType::PENDING); 559 IsActiveTree() ? ElementListType::ACTIVE : ElementListType::PENDING);
567 } 560 }
568 561
569 void LayerTreeImpl::RemoveFromElementMap(LayerImpl* layer) { 562 void LayerTreeImpl::RemoveFromElementMap(LayerImpl* layer) {
570 if (!layer->element_id()) 563 if (!layer->element_id())
571 return; 564 return;
572 565
573 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("compositor-worker"), 566 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("compositor-worker"),
574 "LayerTreeImpl::RemoveFromElementMap", "element", 567 "LayerTreeImpl::RemoveFromElementMap", "element",
575 layer->element_id().AsValue().release(), "layer_id", 568 layer->element_id().AsValue().release(), "layer_id",
(...skipping 1528 matching lines...) Expand 10 before | Expand all | Expand 10 after
2104 2097
2105 void LayerTreeImpl::ResetAllChangeTracking() { 2098 void LayerTreeImpl::ResetAllChangeTracking() {
2106 layers_that_should_push_properties_.clear(); 2099 layers_that_should_push_properties_.clear();
2107 // Iterate over all layers, including masks. 2100 // Iterate over all layers, including masks.
2108 for (auto& layer : *layers_) 2101 for (auto& layer : *layers_)
2109 layer->ResetChangeTracking(); 2102 layer->ResetChangeTracking();
2110 property_trees_.ResetAllChangeTracking(); 2103 property_trees_.ResetAllChangeTracking();
2111 } 2104 }
2112 2105
2113 } // namespace cc 2106 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698