Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2646543003: server/auth: Add TokenSource call. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

server/auth: Add TokenSource call. Add a call to return an oauth2 AsSelf TokenSource from the server/auth package. This allows the "server/auth" package to be used with Google API clients. Specifying manual per-RPC credentials hits a problem with the automagic setup detailed here: https://github.com/google/google-api-go-client/issues/186 Consqeuently, gRPC service libraries (Cloud Datastore, BigTable, Pub/Sub, etc.) require a TokenSource to be provided explicitly. Also make all auth tests run in parallel :) BUG=chromium:682465 TEST=None Review-Url: https://codereview.chromium.org/2646543003 Committed: https://github.com/luci/luci-go/commit/50864029fbaf03ff86650dd64fdd7cfacc7d9a72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -14 lines) Patch
M common/auth/auth.go View 2 chunks +10 lines, -5 lines 0 comments Download
M server/auth/addr_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M server/auth/auth_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M server/auth/cache_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M server/auth/client.go View 5 chunks +37 lines, -4 lines 0 comments Download
M server/auth/client_test.go View 8 chunks +42 lines, -5 lines 0 comments Download
M server/auth/context_test.go View 3 chunks +6 lines, -0 lines 0 comments Download
M server/auth/delegation_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M server/auth/handlers_test.go View 2 chunks +4 lines, -0 lines 0 comments Download
M server/auth/state_test.go View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 11 months ago (2017-01-19 01:02:08 UTC) #2
Vadim Sh.
lgtm thanks!
3 years, 11 months ago (2017-01-19 01:16:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646543003/1
3 years, 11 months ago (2017-01-20 00:05:09 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 00:19:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/50864029fbaf03ff86650dd64fdd7cfacc7d9a72

Powered by Google App Engine
This is Rietveld 408576698