datastorecache: Add Locker field, public settings.

datastorecache: Add Locker field, public settings.

Add the Locker field to datastorecache. Previously, the Locker was not
configurable, and defaulted to memlock. However, locking is optional for
fetching configuration data. This decouples datastorecache from the
requirement that it has a working memcache, allowing it to be used by
other datastore implementations such as cloud.

This also changes the names of the gaeconfig datastore cache settings to
be public so that they can be used by external packages that want to
process the gaeconfig settings.

BUG=chromium:682465
TEST=unit

Review-Url: https://codereview.chromium.org/2645763002
Committed: https://github.com/luci/luci-go/commit/4590aea3339388a2946d2398c536d71789a0ca0a

[dnj, 2017-01-19 01:06:38]

dnj@chromium.org changed reviewers:
+ estaab@chromium.org, iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2017-01-19 01:06:38]

PTAL

[iannucci, 2017-01-19 22:11:20]

lgtm

[dnj, 2017-01-19 23:00:18]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:00:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:03:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484866818352200, "parent_rev":
"5ef3dcbbd5bed80cbb899354a62693c99854ea12", "commit_rev":
"4590aea3339388a2946d2398c536d71789a0ca0a"}

[commit-bot: I haz the power, 2017-01-20 00:03:08]

Description was changed from

==========
datastorecache: Add Locker field, public settings.

Add the Locker field to datastorecache. Previously, the Locker was not
configurable, and defaulted to memlock. However, locking is optional for
fetching configuration data. This decouples datastorecache from the
requirement that it has a working memcache, allowing it to be used by
other datastore implementations such as cloud.

This also changes the names of the gaeconfig datastore cache settings to
be public so that they can be used by external packages that want to
process the gaeconfig settings.

BUG=chromium:682465
TEST=unit
==========

to

==========
datastorecache: Add Locker field, public settings.

Add the Locker field to datastorecache. Previously, the Locker was not
configurable, and defaulted to memlock. However, locking is optional for
fetching configuration data. This decouples datastorecache from the
requirement that it has a working memcache, allowing it to be used by
other datastore implementations such as cloud.

This also changes the names of the gaeconfig datastore cache settings to
be public so that they can be used by external packages that want to
process the gaeconfig settings.

BUG=chromium:682465
TEST=unit

Review-Url: https://codereview.chromium.org/2645763002
Committed:
https://github.com/luci/luci-go/commit/4590aea3339388a2946d2398c536d71789a0ca0a
==========

[commit-bot: I haz the power, 2017-01-20 00:03:11]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/4590aea3339388a2946d2398c536d71789a0ca0a