config: Update remote URL handling.

config: Update remote URL handling.

Remove ServiceURL from "common/config".Interface. The remote inteface
now takes in a "host" (e.g., "example.com") and a boolean, "insecure",
which determines if HTTPS (false) or HTTP (true) should be used.

Update "luci_config/server/cfgclient" to use the "host" and "insecure"
properties.

Update "gaeconfig" to use a host field. For backwards-compatibility
purposes, it will extract the host field from a URL if it has one.

Update the LogDog services API to include the configuration service
host in services.GetConfig.

BUG=chromium:682465
TEST=unit

Review-Url: https://codereview.chromium.org/2643803003
Committed: https://github.com/luci/luci-go/commit/b6f14156e798268e632ddbd6376842144c9c4ae6

[dnj, 2017-01-19 04:39:13]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2017-01-19 04:39:14]

PTAL. This field has always kind of sucked; hopefully this will make it better.

[iannucci, 2017-01-19 19:10:45]

lgtm

[iannucci, 2017-01-19 19:18:02]

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
File luci_config/appengine/gaeconfig/settings.go (right):

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
luci_config/appengine/gaeconfig/settings.go:137: `service. This is the nost name
(e.g., "example.com") of such service. For legacy purposes, this may be a` +
nost

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
luci_config/appengine/gaeconfig/settings.go:223: return u.Host
fyi it looks like "wat.lolol:12345/_ah/api/wut" is weird. *shrug*

[dnj, 2017-01-20 00:29:39]

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
File luci_config/appengine/gaeconfig/settings.go (right):

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
luci_config/appengine/gaeconfig/settings.go:137: `service. This is the nost name
(e.g., "example.com") of such service. For legacy purposes, this may be a` +
On 2017/01/19 19:18:02, iannucci wrote:
> nost

Done.

https://codereview.chromium.org/2643803003/diff/20001/luci_config/appengine/g...
luci_config/appengine/gaeconfig/settings.go:223: return u.Host
On 2017/01/19 19:18:02, iannucci wrote:
> fyi it looks like "wat.lolol:12345/_ah/api/wut" is weird. *shrug*

Acknowledged.

[dnj, 2017-01-20 00:30:09]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-01-20 00:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2643803003/#ps40001
(title: "Fix "nost"")

[commit-bot: I haz the power, 2017-01-20 00:30:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:42:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484872209578360,
"parent_rev": "50864029fbaf03ff86650dd64fdd7cfacc7d9a72", "commit_rev":
"b6f14156e798268e632ddbd6376842144c9c4ae6"}

[commit-bot: I haz the power, 2017-01-20 00:42:47]

Description was changed from

==========
config: Update remote URL handling.

Remove ServiceURL from "common/config".Interface. The remote inteface
now takes in a "host" (e.g., "example.com") and a boolean, "insecure",
which determines if HTTPS (false) or HTTP (true) should be used.

Update "luci_config/server/cfgclient" to use the "host" and "insecure"
properties.

Update "gaeconfig" to use a host field. For backwards-compatibility
purposes, it will extract the host field from a URL if it has one.

Update the LogDog services API to include the configuration service
host in services.GetConfig.

BUG=chromium:682465
TEST=unit
==========

to

==========
config: Update remote URL handling.

Remove ServiceURL from "common/config".Interface. The remote inteface
now takes in a "host" (e.g., "example.com") and a boolean, "insecure",
which determines if HTTPS (false) or HTTP (true) should be used.

Update "luci_config/server/cfgclient" to use the "host" and "insecure"
properties.

Update "gaeconfig" to use a host field. For backwards-compatibility
purposes, it will extract the host field from a URL if it has one.

Update the LogDog services API to include the configuration service
host in services.GetConfig.

BUG=chromium:682465
TEST=unit

Review-Url: https://codereview.chromium.org/2643803003
Committed:
https://github.com/luci/luci-go/commit/b6f14156e798268e632ddbd6376842144c9c4ae6
==========

[commit-bot: I haz the power, 2017-01-20 00:42:48]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/b6f14156e798268e632ddbd6376842144c9c4ae6