Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le… (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, kinuko+watch, abarth-chromium, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, jam, raymes+watch_chromium.org, blink-reviews-bindings_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, Yoav Weiss, nhiroki, loading-reviews_chromium.org, lushnikov+blink_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-permissions_chromium.org, Nate Chapin, darin (slow to review), jochen+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, mlamouri+watch-test-runner_chromium.org, serviceworker-reviews, pfeldman+blink_chromium.org, dominicc+watchlist_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' level. BUG=682521 TBR=(api change) Review-Url: https://codereview.chromium.org/2646033003 Cr-Commit-Position: refs/heads/master@{#445274} Committed: https://chromium.googlesource.com/chromium/src/+/2bcbc12230b01813e2cc5efb02f10a8da79f88ce

Patch Set 1 #

Patch Set 2 : same with front-end fixes #

Total comments: 3

Patch Set 3 : fixed tests, addressed comments #

Patch Set 4 : missing rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -169 lines) Patch
M chrome/browser/installable/installable_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_frame_test_client.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browsing_data/clear_site_data_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/appcache_frontend_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/appcache_interfaces.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/common/console_message_level.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/host_globals.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M extensions/renderer/console.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/console-functions-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-console-log-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test-expected.txt View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-before-inspector-open-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-nested-group-expected.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-preserve-log.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleTypes.h View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Console.js View 1 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 3 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/smallBubble.css View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/ConsoleMessageStructTraits.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebConsoleMessage.h View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/console_message.mojom View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
pfeldman
3 years, 11 months ago (2017-01-20 02:11:02 UTC) #8
dgozman
lgtm, but I'm sure you missed some places. Hopefully, bots will reveal those. https://codereview.chromium.org/2646033003/diff/20001/content/browser/bluetooth/bluetooth_device_chooser_controller.cc File ...
3 years, 11 months ago (2017-01-20 17:26:33 UTC) #11
pfeldman
All done.
3 years, 11 months ago (2017-01-20 20:19:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646033003/40001
3 years, 11 months ago (2017-01-20 20:22:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368060)
3 years, 11 months ago (2017-01-20 22:30:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646033003/60001
3 years, 11 months ago (2017-01-20 22:36:53 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368262)
3 years, 11 months ago (2017-01-21 03:00:09 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646033003/60001
3 years, 11 months ago (2017-01-21 04:29:39 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 06:09:33 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2bcbc12230b01813e2cc5efb02f1...

Powered by Google App Engine
This is Rietveld 408576698