Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le… (Closed)
Patch Set: missing rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 return exception->toStringForConsole(); 116 return exception->toStringForConsole();
117 } 117 }
118 } 118 }
119 return emptyString(); 119 return emptyString();
120 } 120 }
121 121
122 namespace { 122 namespace {
123 MessageLevel MessageLevelFromNonFatalErrorLevel(int errorLevel) { 123 MessageLevel MessageLevelFromNonFatalErrorLevel(int errorLevel) {
124 MessageLevel level = ErrorMessageLevel; 124 MessageLevel level = ErrorMessageLevel;
125 switch (errorLevel) { 125 switch (errorLevel) {
126 case v8::Isolate::kMessageDebug:
127 level = VerboseMessageLevel;
128 break;
126 case v8::Isolate::kMessageLog: 129 case v8::Isolate::kMessageLog:
127 level = LogMessageLevel; 130 case v8::Isolate::kMessageInfo:
131 level = InfoMessageLevel;
128 break; 132 break;
129 case v8::Isolate::kMessageWarning: 133 case v8::Isolate::kMessageWarning:
130 level = WarningMessageLevel; 134 level = WarningMessageLevel;
131 break; 135 break;
132 case v8::Isolate::kMessageDebug:
133 level = DebugMessageLevel;
134 break;
135 case v8::Isolate::kMessageInfo:
136 level = InfoMessageLevel;
137 break;
138 case v8::Isolate::kMessageError: 136 case v8::Isolate::kMessageError:
139 level = InfoMessageLevel; 137 level = InfoMessageLevel;
140 break; 138 break;
141 default: 139 default:
142 NOTREACHED(); 140 NOTREACHED();
143 } 141 }
144 return level; 142 return level;
145 } 143 }
146 } // namespace 144 } // namespace
147 145
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 v8::Isolate::kMessageLog); 520 v8::Isolate::kMessageLog);
523 isolate->SetFatalErrorHandler(reportFatalErrorInWorker); 521 isolate->SetFatalErrorHandler(reportFatalErrorInWorker);
524 522
525 uint32_t here; 523 uint32_t here;
526 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) - 524 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) -
527 kWorkerMaxStackSize); 525 kWorkerMaxStackSize);
528 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker); 526 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker);
529 } 527 }
530 528
531 } // namespace blink 529 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698