third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js - Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le… (Closed)

Patch Set: missing rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

index 5e8198c449e17d2b55f7353ccfcccbf5c53ebfe2..bc047d8cb673715d38dea9c3812c910e3be33a09 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

@@ -396,14 +396,14 @@ SDK.RuntimeDispatcher = class {

* @param {!Protocol.Runtime.StackTrace=} stackTrace

consoleAPICalled(type, args, executionContextId, timestamp, stackTrace) {

- var level = SDK.ConsoleMessage.MessageLevel.Log;

+ var level = SDK.ConsoleMessage.MessageLevel.Info;

if (type === SDK.ConsoleMessage.MessageType.Debug)

- level = SDK.ConsoleMessage.MessageLevel.Debug;

+ level = SDK.ConsoleMessage.MessageLevel.Verbose;

if (type === SDK.ConsoleMessage.MessageType.Error || type === SDK.ConsoleMessage.MessageType.Assert)

level = SDK.ConsoleMessage.MessageLevel.Error;

if (type === SDK.ConsoleMessage.MessageType.Warning)

level = SDK.ConsoleMessage.MessageLevel.Warning;

- if (type === SDK.ConsoleMessage.MessageType.Info)

+ if (type === SDK.ConsoleMessage.MessageType.Info || type === SDK.ConsoleMessage.MessageType.Log)

level = SDK.ConsoleMessage.MessageLevel.Info;

var message = '';

if (args.length && typeof args[0].value === 'string')