Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issue 2645723002: [DevTools] use command line API during selection evaluation in console (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
einbinder, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] use command line API during selection evaluation in console BUG=chromium:680116 R=einbinder@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2645723002 Cr-Commit-Position: refs/heads/master@{#444543} Committed: https://chromium.googlesource.com/chromium/src/+/57b9ce859ef097374f8ed46df3ffa66eefa0f243

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kozy
Joel, please take a look.
3 years, 11 months ago (2017-01-18 21:39:01 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode961 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:961: /* evaluateCommandInConsole*/ false); Wrong comment.
3 years, 11 months ago (2017-01-18 21:57:25 UTC) #2
kozy
thanks! all done. https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode961 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:961: /* evaluateCommandInConsole*/ false); On 2017/01/18 21:57:24, ...
3 years, 11 months ago (2017-01-18 22:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645723002/20001
3 years, 11 months ago (2017-01-18 22:03:54 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 23:31:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57b9ce859ef097374f8ed46df3ff...

Powered by Google App Engine
This is Rietveld 408576698