[DevTools] use command line API during selection evaluation in console

[DevTools] use command line API during selection evaluation in console

BUG=chromium:680116
R=einbinder@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2645723002
Cr-Commit-Position: refs/heads/master@{#444543}
Committed: https://chromium.googlesource.com/chromium/src/+/57b9ce859ef097374f8ed46df3ffa66eefa0f243

[kozy, 2017-01-18 21:39:01]

Joel, please take a look.

[dgozman, 2017-01-18 21:57:25]

lgtm

https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:961: /*
evaluateCommandInConsole*/ false);
Wrong comment.

[kozy, 2017-01-18 22:03:05]

thanks!
all done.

https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2645723002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:961: /*
evaluateCommandInConsole*/ false);
On 2017/01/18 21:57:24, dgozman wrote:
> Wrong comment.

Done.

[kozy, 2017-01-18 22:03:08]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 22:03:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2645723002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-18 22:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 23:30:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484776988848780,
"parent_rev": "1a4d8656d2df7c86c020956cdbf995d813021449", "commit_rev":
"57b9ce859ef097374f8ed46df3ffa66eefa0f243"}

[commit-bot: I haz the power, 2017-01-18 23:31:07]

Description was changed from

==========
[DevTools] use command line API during selection evaluation in console

BUG=chromium:680116
R=einbinder@chromium.org,dgozman@chromium.org
==========

to

==========
[DevTools] use command line API during selection evaluation in console

BUG=chromium:680116
R=einbinder@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2645723002
Cr-Commit-Position: refs/heads/master@{#444543}
Committed:
https://chromium.googlesource.com/chromium/src/+/57b9ce859ef097374f8ed46df3ff...
==========

[commit-bot: I haz the power, 2017-01-18 23:31:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57b9ce859ef097374f8ed46df3ff...