Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2645723002: [DevTools] use command line API during selection evaluation in console (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
index 8fa80f7c57b6b2befd4b150389b7a0be0e4345af..fb351a76ab733b0efbf92b268b38ef66f8901d18 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
@@ -63,7 +63,7 @@ SDK.ConsoleModel = class extends SDK.SDKModel {
/**
* @param {!SDK.ExecutionContext} executionContext
* @param {string} text
- * @param {boolean=} useCommandLineAPI
+ * @param {boolean} useCommandLineAPI
*/
static evaluateCommandInConsole(executionContext, text, useCommandLineAPI) {
var target = executionContext.target();
@@ -116,7 +116,7 @@ SDK.ConsoleModel = class extends SDK.SDKModel {
if (looksLikeAnObjectLiteral(text))
text = '(' + text + ')';
- executionContext.evaluate(text, 'console', !!useCommandLineAPI, false, false, true, true, printResult);
+ executionContext.evaluate(text, 'console', useCommandLineAPI, false, false, true, true, printResult);
Host.userMetrics.actionTaken(Host.UserMetrics.Action.ConsoleEvaluated);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698