Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2645723002: [DevTools] use command line API during selection evaluation in console (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index ba2ade0b7863001cbfe64aa2d178a7e7957e8785..eb320438c2ff57fdefe347673988387928ffa9bc 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -957,7 +957,8 @@ Sources.SourcesPanel = class extends UI.Panel {
failedToSave(result);
} else {
SDK.ConsoleModel.evaluateCommandInConsole(
- /** @type {!SDK.ExecutionContext} */ (currentExecutionContext), result.value);
+ /** @type {!SDK.ExecutionContext} */ (currentExecutionContext), result.value,
+ /* useCommandLineAPI */ false);
}
}
@@ -1267,7 +1268,7 @@ Sources.SourcesPanel.DebuggingActionDelegate = class {
var text = frame.textEditor.text(frame.textEditor.selection());
var executionContext = UI.context.flavor(SDK.ExecutionContext);
if (executionContext)
- SDK.ConsoleModel.evaluateCommandInConsole(executionContext, text);
+ SDK.ConsoleModel.evaluateCommandInConsole(executionContext, text, /* useCommandLineAPI */ true);
}
return true;
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698