Add an aura window property for Immersive fullscreen mode

Add an aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496
Review-Url: https://codereview.chromium.org/2645673003
Cr-Commit-Position: refs/heads/master@{#446212}
Committed: https://chromium.googlesource.com/chromium/src/+/178529af33287d1459efceca6454f768f62afe7b

[Peng, 2017-01-23 21:05:45]

Description was changed from

==========
Immersive fullscreen mode

BUG=
==========

to

==========
Add a aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496
==========

[Peng, 2017-01-23 21:06:32]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2017-01-23 21:06:32]

Hi sky, PTAL. Thanks.

[sky, 2017-01-23 21:48:56]

https://codereview.chromium.org/2645673003/diff/1/ash/common/wm_window.cc
File ash/common/wm_window.cc (right):

https://codereview.chromium.org/2645673003/diff/1/ash/common/wm_window.cc#new...
ash/common/wm_window.cc:964: bool enable =
window_->GetProperty(aura::client::kImmersiveFullscreenKey);
You'll need to mirror this to a WindowManager property and register it with
PropertyConverter, otherwise when clients change the value mash won't be able to
pick it up.

[sky, 2017-01-23 21:57:36]

Could you also clarify why exo needs to set this property? Does exo have a
control on windows for entering immersive mode?

[Peng, 2017-01-25 16:18:57]

https://codereview.chromium.org/2645673003/diff/1/ash/common/wm_window.cc
File ash/common/wm_window.cc (right):

https://codereview.chromium.org/2645673003/diff/1/ash/common/wm_window.cc#new...
ash/common/wm_window.cc:964: bool enable =
window_->GetProperty(aura::client::kImmersiveFullscreenKey);
On 2017/01/23 21:48:56, sky wrote:
> You'll need to mirror this to a WindowManager property and register it with
> PropertyConverter, otherwise when clients change the value mash won't be able
to
> pick it up.

Done.

[Peng, 2017-01-25 16:22:33]

On 2017/01/23 21:57:36, sky wrote:
> Could you also clarify why exo needs to set this property? Does exo have a
> control on windows for entering immersive mode?



Please check CL https://codereview.chromium.org/2508563002.

Looks like we want to disable those gestures which is for exiting
the fullscreen mode for arc++ apps.

[Peng, 2017-01-25 16:38:28]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 16:38:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 17:27:33]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-25 17:42:12]

https://codereview.chromium.org/2645673003/diff/20001/ash/common/wm_window.cc
File ash/common/wm_window.cc (right):

https://codereview.chromium.org/2645673003/diff/20001/ash/common/wm_window.cc...
ash/common/wm_window.cc:940: if (key == aura::client::kImmersiveFullscreenKey) {
The description doesn't match usage of the property. You describe the property
as if fullscreen should be treated as immersive, where as setting the value here
means the window is in immersive now.

[Peng, 2017-01-25 19:02:38]

https://codereview.chromium.org/2645673003/diff/20001/ash/common/wm_window.cc
File ash/common/wm_window.cc (right):

https://codereview.chromium.org/2645673003/diff/20001/ash/common/wm_window.cc...
ash/common/wm_window.cc:940: if (key == aura::client::kImmersiveFullscreenKey) {
On 2017/01/25 17:42:12, sky wrote:
> The description doesn't match usage of the property. You describe the property
> as if fullscreen should be treated as immersive, where as setting the value
here
> means the window is in immersive now.

See [1], the in_immersive_fullscreen() is only useful when the window is
fullscreen. So probably in_immersive_fullscreen() should be renamed to
is_immersive_fullscreen() to match its usage.

[1]
https://cs.chromium.org/chromium/src/ash/common/wm/maximize_mode/maximize_mod...

[Peng, 2017-01-25 19:48:07]

Description was changed from

==========
Add a aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496
==========

to

==========
Add an aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496
==========

[sky, 2017-01-25 21:58:39]

Ok, LGTM

[Peng, 2017-01-25 22:01:53]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:15:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peng, 2017-01-25 23:37:18]

penghuang@chromium.org changed reviewers:
+ dcheng@chromium.org

[Peng, 2017-01-25 23:37:18]

+dcheng for mojom 

Hi Daniel, PTAL. Thanks.

[dcheng, 2017-01-26 02:00:33]

rs lgtm for mojom

[Peng, 2017-01-26 02:31:05]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 02:38:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485397865839170,
"parent_rev": "3914e2b6974d1dacd3ba06a752aae856836fde22", "commit_rev":
"178529af33287d1459efceca6454f768f62afe7b"}

[commit-bot: I haz the power, 2017-01-26 02:39:32]

Description was changed from

==========
Add an aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496
==========

to

==========
Add an aura window property for Immersive fullscreen mode

Add a property kImmersiveFullscreen, so the exo doesn't
need access wm::WindowState::set_in_immersive_fullscreen
directly.

BUG=670496

Review-Url: https://codereview.chromium.org/2645673003
Cr-Commit-Position: refs/heads/master@{#446212}
Committed:
https://chromium.googlesource.com/chromium/src/+/178529af33287d1459efceca6454...
==========

[commit-bot: I haz the power, 2017-01-26 02:39:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/178529af33287d1459efceca6454...