Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2508563002:
Make the arc++ fullscreen as immersive fullscreen (Closed)
DescriptionMake the arc++ fullscreen as immersive fullscreen
A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same.
I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort.
BUG=b/32883349
Committed: https://crrev.com/a19689ec6eea30b5f75b80f6af87185dea7661eb
Cr-Commit-Position: refs/heads/master@{#432518}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Make the arc++ fullscreen as immersive fullscreen #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Description was changed from ========== Make the arc++ fullscreen as immersive fullscreen BUG=b/32883349 ========== to ========== Make the arc++ fullscreen as immersive fullscreen BUG=b/32883349 ==========
oshima@chromium.org changed reviewers: + reveman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can you explain a bit more in the description what this does to the user experience. It's not perfectly clear to me what immersive vs non-immersive fullscreen mode is. Also, this is not limited to arc++ clients but effects all shell surface clients (not saying that's a bad thing), right? https://codereview.chromium.org/2508563002/diff/1/components/exo/shell_surfac... File components/exo/shell_surface.cc (right): https://codereview.chromium.org/2508563002/diff/1/components/exo/shell_surfac... components/exo/shell_surface.cc:167: nit: blankline intentional? Why is set_in_immersive_fullscreen grouped with UpdateShelfStateForFullscreenChange but SetFullscreen is not?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== Make the arc++ fullscreen as immersive fullscreen BUG=b/32883349 ========== to ========== Make the arc++ fullscreen as immersive fullscreen A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same. I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort. BUG=b/32883349 ==========
updated the description https://codereview.chromium.org/2508563002/diff/1/components/exo/shell_surfac... File components/exo/shell_surface.cc (right): https://codereview.chromium.org/2508563002/diff/1/components/exo/shell_surfac... components/exo/shell_surface.cc:167: On 2016/11/15 23:07:37, reveman wrote: > nit: blankline intentional? Why is set_in_immersive_fullscreen grouped with > UpdateShelfStateForFullscreenChange but SetFullscreen is not? removed new line
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make the arc++ fullscreen as immersive fullscreen A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same. I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort. BUG=b/32883349 ========== to ========== Make the arc++ fullscreen as immersive fullscreen A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same. I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort. BUG=b/32883349 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make the arc++ fullscreen as immersive fullscreen A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same. I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort. BUG=b/32883349 ========== to ========== Make the arc++ fullscreen as immersive fullscreen A user can restore a html/pepper fullscreen window by swipe gesture in tablet mode. We do not want this for other types of windows (in chromeos, they're marked immersive fullscreen), and this will make all exo windows to behave the same. I believe the current UI isn't ideal, and we'll revisit this as a part of tablet effort. BUG=b/32883349 Committed: https://crrev.com/a19689ec6eea30b5f75b80f6af87185dea7661eb Cr-Commit-Position: refs/heads/master@{#432518} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a19689ec6eea30b5f75b80f6af87185dea7661eb Cr-Commit-Position: refs/heads/master@{#432518} |
