Add an aura window property for Immersive fullscreen mode

ash/common/wm_window.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm_window.h"
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/ash_constants.h"
 #include "ash/common/shelf/shelf_item_types.h"
@@ skipping 919 matching lines @@
     observer.OnWindowStackingChanged(this);
 }
 
 void WmWindow::OnWindowPropertyChanged(aura::Window* window,
                                        const void* key,
                                        intptr_t old) {
   if (key == aura::client::kShowStateKey) {
     ash::wm::GetWindowState(window_)->OnWindowShowStateChanged();
     return;
   }
+  if (key == aura::client::kImmersiveFullscreenKey) {

[sky, 2017/01/25 17:42:12]

The description doesn't match usage of the property. You describe the property
as if fullscreen should be treated as immersive, where as setting the value here
means the window is in immersive now.

[Peng, 2017/01/25 19:02:38]

See [1], the in_immersive_fullscreen() is only useful when the window is
fullscreen. So probably in_immersive_fullscreen() should be renamed to
is_immersive_fullscreen() to match its usage.

[1]
https://cs.chromium.org/chromium/src/ash/common/wm/maximize_mode/maximize_mod...

+    bool enable = window_->GetProperty(aura::client::kImmersiveFullscreenKey);
+    GetWindowState()->set_in_immersive_fullscreen(enable);
+    return;
+  }
   WmWindowProperty wm_property;
   if (key == aura::client::kAlwaysOnTopKey) {
     wm_property = WmWindowProperty::ALWAYS_ON_TOP;
   } else if (key == aura::client::kAppIconKey) {
     wm_property = WmWindowProperty::APP_ICON;
   } else if (key == aura::client::kDrawAttentionKey) {
     wm_property = WmWindowProperty::DRAW_ATTENTION;
   } else if (key == aura::client::kModalKey) {
     wm_property = WmWindowProperty::MODAL_TYPE;
   } else if (key == kPanelAttachedKey) {
@@ skipping 54 matching lines @@
     observer.OnTransientChildAdded(this, Get(transient));
 }
 
 void WmWindow::OnTransientChildRemoved(aura::Window* window,
                                        aura::Window* transient) {
   for (auto& observer : transient_observers_)
     observer.OnTransientChildRemoved(this, Get(transient));
 }
 
 }  // namespace ash