Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2645523003: Build ozone/linux_os with jessie sysroot when use_ozone=true (Closed)

Created:
3 years, 11 months ago by tonikitoo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build ozone/linux_os with jessie sysroot when use_ozone=true This is needed because Debian/wheezy (currently used) does not support libxkbcommon0/libxkbcommon-dev packages, needed for keyboard support on Ozone/Wayland. BUG=681562 Review-Url: https://codereview.chromium.org/2645523003 Cr-Commit-Position: refs/heads/master@{#446081} Committed: https://chromium.googlesource.com/chromium/src/+/58f836955cb7ca30cffc60a95bc337a5b6fa092c

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed tom's feedback #

Total comments: 2

Patch Set 3 : addressed dpranke's feedback #

Total comments: 1

Patch Set 4 : addressed moar dpranke's feedback #

Total comments: 3

Patch Set 5 : excluding chromecast builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/config/sysroot.gni View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (14 generated)
tonikitoo
So Tom. ChromeOS/desktop builds still use Ubuntu/precise (12.04?!) as seeing in build/config/sysroot.gni. Also, in build/linux/sysroot_scripts/install-sysroot.py, ...
3 years, 11 months ago (2017-01-18 13:03:09 UTC) #3
tonikitoo
On 2017/01/18 13:03:09, tonikitoo wrote: > So Tom. ChromeOS/desktop builds still use Ubuntu/precise (12.04?!) as ...
3 years, 11 months ago (2017-01-18 13:26:24 UTC) #4
Tom (Use chromium acct)
I should give you some background about what we have planned with the sysroots. We're ...
3 years, 11 months ago (2017-01-18 19:02:18 UTC) #6
Tom (Use chromium acct)
I should give you some background about what we have planned with the sysroots. We're ...
3 years, 11 months ago (2017-01-18 19:02:19 UTC) #7
tonikitoo
Addressed both comments, Tom. do we need a way to enforce pulling debian/jessie sysroot for ...
3 years, 11 months ago (2017-01-20 20:26:22 UTC) #9
tonikitoo
On 2017/01/18 19:02:19, Tom Anderson wrote: > I should give you some background about what ...
3 years, 11 months ago (2017-01-20 20:29:05 UTC) #10
Tom (Use chromium acct)
thanks this lgtm. You'll also need dpranke@'s approval I'll be making the necessary changes in ...
3 years, 11 months ago (2017-01-20 21:07:59 UTC) #12
Dirk Pranke
https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni#newcode61 build/config/sysroot.gni:61: import("//ui/base/ui_features.gni") The //build files are used in other repos, ...
3 years, 11 months ago (2017-01-23 21:59:48 UTC) #13
tonikitoo
https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni#newcode61 build/config/sysroot.gni:61: import("//ui/base/ui_features.gni") On 2017/01/23 21:59:48, Dirk Pranke wrote: > The ...
3 years, 11 months ago (2017-01-24 03:28:03 UTC) #14
tonikitoo
On 2017/01/24 03:28:03, tonikitoo wrote: > https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni > File build/config/sysroot.gni (right): > > https://codereview.chromium.org/2645523003/diff/20001/build/config/sysroot.gni#newcode61 > ...
3 years, 11 months ago (2017-01-24 03:37:47 UTC) #15
tonikitoo
Friendly ping :-)
3 years, 11 months ago (2017-01-24 21:04:27 UTC) #17
Dirk Pranke
sorry for the delay, I'll try to be faster on the next cycle. https://codereview.chromium.org/2645523003/diff/40001/build/config/sysroot.gni File ...
3 years, 11 months ago (2017-01-24 22:49:21 UTC) #18
tonikitoo
On 2017/01/24 22:49:21, Dirk Pranke wrote: > sorry for the delay, I'll try to be ...
3 years, 11 months ago (2017-01-25 00:18:35 UTC) #19
Dirk Pranke
https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni#newcode69 build/config/sysroot.gni:69: } you need else clauses here for !build_with_chromium and ...
3 years, 11 months ago (2017-01-25 00:46:18 UTC) #20
tonikitoo
https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni#newcode69 build/config/sysroot.gni:69: } On 2017/01/25 00:46:18, Dirk Pranke wrote: > you ...
3 years, 11 months ago (2017-01-25 01:09:03 UTC) #21
Dirk Pranke
lgtm. https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/2645523003/diff/60001/build/config/sysroot.gni#newcode69 build/config/sysroot.gni:69: } On 2017/01/25 01:09:03, tonikitoo wrote: > On ...
3 years, 11 months ago (2017-01-25 02:43:07 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645523003/60001
3 years, 11 months ago (2017-01-25 03:28:26 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/199555)
3 years, 11 months ago (2017-01-25 03:36:53 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645523003/80001
3 years, 11 months ago (2017-01-25 16:47:30 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/58f836955cb7ca30cffc60a95bc337a5b6fa092c
3 years, 11 months ago (2017-01-25 19:24:44 UTC) #33
brettw
I really don't think that build should be depending on non-build directories. Putting things behind ...
3 years, 11 months ago (2017-01-26 22:48:36 UTC) #35
Dirk Pranke
On 2017/01/26 22:48:36, brettw (ping after 24h) wrote: > I really don't think that build ...
3 years, 11 months ago (2017-01-26 22:51:42 UTC) #36
tonikitoo
On 2017/01/26 22:51:42, Dirk Pranke wrote: > On 2017/01/26 22:48:36, brettw (ping after 24h) wrote: ...
3 years, 10 months ago (2017-01-27 13:53:25 UTC) #37
Dirk Pranke
3 years, 10 months ago (2017-01-27 15:36:12 UTC) #38
Message was sent while issue was closed.
On 2017/01/27 13:53:25, tonikitoo wrote:
> Can I get cc'ed to
https://bugs.chromium.org/p/chromium/issues/detail?id=666825
> please (It tracks the wheezy -> jessie sysroot upgrade, but seems restricted
for
> non-googlers).

Unfortunately, no :(.

That bug contains a bunch of discussion of upgrading Google-internal systems as
well.

But, don't worry, we'll let you know when enough things are upgraded and it's
safe to
remove this.

Powered by Google App Engine
This is Rietveld 408576698