Download Jessie sysroot on ozone builds

Download Jessie sysroot on ozone builds

BUG=681562
R=dpranke@chromium.org
CC=tonikitoo@igalia.com

Review-Url: https://codereview.chromium.org/2645733006
Cr-Commit-Position: refs/heads/master@{#445588}
Committed: https://chromium.googlesource.com/chromium/src/+/c2d68eae813e2234e28798e81c423df7946fbe01

[tonikitoo, 2017-01-20 22:06:32]

On 2017/01/20 21:36:57, Tom Anderson wrote:

Informal l g t m. Thanks!

Note that on the other CL I also conditioned it with 'use_xkbcommon'.

[Tom (Use chromium acct), 2017-01-23 22:22:02]

pinging dpranke@

On 2017/01/20 22:06:32, tonikitoo wrote:
> Note that on the other CL I also conditioned it with 'use_xkbcommon'.

please see https://chromium-review.googlesource.com/#/c/430993/
I don't believe the ozone config adds use_xkbcommon to GYP_DEFINES.

[Dirk Pranke, 2017-01-23 22:39:53]

lgtm

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/install-sysroot.py:131: # then install the sysroot
too.  Don't attampt to install arm64
Nit: s/attampt/attempt

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/install-sysroot.py:142: if 'use_ozone' in
gyp_defines and gyp_defines['use_ozone'] == '1':
Nit: 

   if gyp_defines.get('use_ozone') == '1':

[Tom (Use chromium acct), 2017-01-24 01:30:00]

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/install-sysroot.py:131: # then install the sysroot
too.  Don't attampt to install arm64
On 2017/01/23 22:39:53, Dirk Pranke wrote:
> Nit: s/attampt/attempt

Done.

https://codereview.chromium.org/2645733006/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/install-sysroot.py:142: if 'use_ozone' in
gyp_defines and gyp_defines['use_ozone'] == '1':
On 2017/01/23 22:39:53, Dirk Pranke wrote:
> Nit: 
> 
>    if gyp_defines.get('use_ozone') == '1':

Done.

[Tom (Use chromium acct), 2017-01-24 01:30:13]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-01-24 01:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2645733006/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2017-01-24 01:31:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:50:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485221413795610,
"parent_rev": "156cf04a115280d5e465d1c38f2be680572096e5", "commit_rev":
"c2d68eae813e2234e28798e81c423df7946fbe01"}

[commit-bot: I haz the power, 2017-01-24 01:51:51]

Description was changed from

==========
Download Jessie sysroot on ozone builds

BUG=681562
R=dpranke@chromium.org
CC=tonikitoo@igalia.com
==========

to

==========
Download Jessie sysroot on ozone builds

BUG=681562
R=dpranke@chromium.org
CC=tonikitoo@igalia.com

Review-Url: https://codereview.chromium.org/2645733006
Cr-Commit-Position: refs/heads/master@{#445588}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2d68eae813e2234e28798e81c42...
==========

[commit-bot: I haz the power, 2017-01-24 01:51:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2d68eae813e2234e28798e81c42...