Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2645133002: WifiDataProviderChromeOs: Call NetworkHandler from correct task runner. (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

WifiDataProviderChromeOs: Call NetworkHandler from correct task runner. At some point, WifiDataProviderChromeOs construction changed to the GeolocationProviderImpl thread, making the following code in its constructor incorrect: main_task_runner_(base::ThreadTaskRunnerHandle::Get()) Rather than relying on a "main" task runner for NetworkHandger calls, use NetworkHandler::Get()->task_runner() instead. BUG=674153, 661304 Review-Url: https://codereview.chromium.org/2584733002 Cr-Commit-Position: refs/heads/master@{#439253} (cherry picked from commit 43c6a582d94fe6ec49330636c819601650f63a24) Review-Url: https://codereview.chromium.org/2645133002 . Cr-Commit-Position: refs/branch-heads/2924@{#818} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/4c7e0db8fdd332bda882e134f8f58b73a7a6f0aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M device/geolocation/wifi_data_provider_chromeos.h View 3 chunks +2 lines, -10 lines 0 comments Download
M device/geolocation/wifi_data_provider_chromeos.cc View 7 chunks +29 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
3 years, 11 months ago (2017-01-20 17:30:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c7e0db8fdd332bda882e134f8f58b73a7a6f0aa.

Powered by Google App Engine
This is Rietveld 408576698