WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

device/geolocation/wifi_data_provider_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Provides wifi scan API binding for chromeos, using proprietary APIs.
 
 #include "device/geolocation/wifi_data_provider_chromeos.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
-#include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/threading/thread_task_runner_handle.h"
 #include "chromeos/network/geolocation_handler.h"
+#include "chromeos/network/network_handler.h"
 #include "device/geolocation/wifi_data_provider_manager.h"
 
+using chromeos::NetworkHandler;
+
 namespace device {
 
 namespace {
 
 // The time periods between successive polls of the wifi data.
 const int kDefaultPollingIntervalMilliseconds = 10 * 1000;           // 10s
 const int kNoChangePollingIntervalMilliseconds = 2 * 60 * 1000;      // 2 mins
 const int kTwoNoChangePollingIntervalMilliseconds = 10 * 60 * 1000;  // 10 mins
 const int kNoWifiPollingIntervalMilliseconds = 20 * 1000;            // 20s
 
 }  // namespace
 
 WifiDataProviderChromeOs::WifiDataProviderChromeOs()
-    : started_(false),
-      is_first_scan_complete_(false),
-      main_task_runner_(base::ThreadTaskRunnerHandle::Get()) {}
+    : started_(false), is_first_scan_complete_(false) {}
 
 WifiDataProviderChromeOs::~WifiDataProviderChromeOs() {}
 
 void WifiDataProviderChromeOs::StartDataProvider() {
   DCHECK(CalledOnClientThread());
 
-  DCHECK(polling_policy_ == NULL);
+  DCHECK(polling_policy_ == nullptr);
   polling_policy_.reset(
       new GenericWifiPollingPolicy<kDefaultPollingIntervalMilliseconds,
                                    kNoChangePollingIntervalMilliseconds,
                                    kTwoNoChangePollingIntervalMilliseconds,
                                    kNoWifiPollingIntervalMilliseconds>);
 
   ScheduleStart();
 }
 
 void WifiDataProviderChromeOs::StopDataProvider() {
   DCHECK(CalledOnClientThread());
 
   polling_policy_.reset();
   ScheduleStop();
 }
 
 bool WifiDataProviderChromeOs::GetData(WifiData* data) {
   DCHECK(CalledOnClientThread());
   DCHECK(data);
   *data = wifi_data_;
   return is_first_scan_complete_;
 }
 
-void WifiDataProviderChromeOs::DoStartTaskOnUIThread() {
-  CHECK(main_task_runner_->BelongsToCurrentThread());
-  DoWifiScanTaskOnUIThread();
-}
-
-void WifiDataProviderChromeOs::DoWifiScanTaskOnUIThread() {
-  CHECK(main_task_runner_->BelongsToCurrentThread());
-
+void WifiDataProviderChromeOs::DoWifiScanTaskOnNetworkHandlerThread() {
   // This method could be scheduled after a ScheduleStop.
   if (!started_)
     return;
 
   WifiData new_data;
 
   if (GetAccessPointData(&new_data.access_point_data)) {
     client_task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&WifiDataProviderChromeOs::DidWifiScanTask, this, new_data));
   } else {
     client_task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&WifiDataProviderChromeOs::DidWifiScanTaskNoResults, this));
   }
 }
 
 void WifiDataProviderChromeOs::DidWifiScanTaskNoResults() {
   DCHECK(CalledOnClientThread());
   // Schedule next scan if started (StopDataProvider could have been called
-  // in between DoWifiScanTaskOnUIThread and this method).
+  // in between DoWifiScanTaskOnNetworkHandlerThread and this method).
   if (started_)
     ScheduleNextScan(polling_policy_->NoWifiInterval());
 }
 
 void WifiDataProviderChromeOs::DidWifiScanTask(const WifiData& new_data) {
   DCHECK(CalledOnClientThread());
   bool update_available = wifi_data_.DiffersSignificantly(new_data);
   wifi_data_ = new_data;
   // Schedule next scan if started (StopDataProvider could have been called
-  // in between DoWifiScanTaskOnUIThread and this method).
+  // in between DoWifiScanTaskOnNetworkHandlerThread and this method).
   if (started_) {
     polling_policy_->UpdatePollingInterval(update_available);
     ScheduleNextScan(polling_policy_->PollingInterval());
   }
 
   if (update_available || !is_first_scan_complete_) {
     is_first_scan_complete_ = true;
     RunCallbacks();
   }
 }
 
 void WifiDataProviderChromeOs::ScheduleNextScan(int interval) {
   DCHECK(CalledOnClientThread());
   DCHECK(started_);
-  main_task_runner_->PostDelayedTask(
+  if (!NetworkHandler::IsInitialized()) {
+    LOG(ERROR) << "ScheduleNextScan called with uninitialized NetworkHandler";
+    return;
+  }
+  NetworkHandler::Get()->task_runner()->PostDelayedTask(
       FROM_HERE,
-      base::Bind(&WifiDataProviderChromeOs::DoWifiScanTaskOnUIThread, this),
+      base::Bind(
+          &WifiDataProviderChromeOs::DoWifiScanTaskOnNetworkHandlerThread,
+          this),
       base::TimeDelta::FromMilliseconds(interval));
 }
 
 void WifiDataProviderChromeOs::ScheduleStop() {
   DCHECK(CalledOnClientThread());
   DCHECK(started_);
   started_ = false;
 }
 
 void WifiDataProviderChromeOs::ScheduleStart() {
   DCHECK(CalledOnClientThread());
   DCHECK(!started_);
+  if (!NetworkHandler::IsInitialized()) {
+    LOG(ERROR) << "ScheduleStart called with uninitialized NetworkHandler";
+    return;
+  }
   started_ = true;
   // Perform first scan ASAP regardless of the polling policy. If this scan
   // fails we'll retry at a rate in line with the polling policy.
-  main_task_runner_->PostTask(
+  NetworkHandler::Get()->task_runner()->PostTask(
       FROM_HERE,
-      base::Bind(&WifiDataProviderChromeOs::DoStartTaskOnUIThread, this));
+      base::Bind(
+          &WifiDataProviderChromeOs::DoWifiScanTaskOnNetworkHandlerThread,
+          this));
 }
 
 bool WifiDataProviderChromeOs::GetAccessPointData(
     WifiData::AccessPointDataSet* result) {
-  // If in startup or shutdown, chromeos::NetworkHandler is uninitialized.
-  if (!chromeos::NetworkHandler::IsInitialized())
+  // If in startup or shutdown, NetworkHandler is uninitialized.
+  if (!NetworkHandler::IsInitialized())
     return false;  // Data not ready.
 
+  DCHECK(NetworkHandler::Get()->task_runner()->BelongsToCurrentThread());
+
   // If wifi isn't enabled, we've effectively completed the task.
   chromeos::GeolocationHandler* const geolocation_handler =
-      chromeos::NetworkHandler::Get()->geolocation_handler();
+      NetworkHandler::Get()->geolocation_handler();
   if (!geolocation_handler || !geolocation_handler->wifi_enabled())
     return true;  // Access point list is empty, no more data.
 
   chromeos::WifiAccessPointVector access_points;
   int64_t age_ms = 0;
   if (!geolocation_handler->GetWifiAccessPoints(&access_points, &age_ms))
     return false;
 
   for (const auto& access_point : access_points) {
     AccessPointData ap_data;
@@ skipping 10 matching lines @@
     return false;
   return true;
 }
 
 // static
 WifiDataProvider* WifiDataProviderManager::DefaultFactoryFunction() {
   return new WifiDataProviderChromeOs();
 }
 
 }  // namespace device