WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304
Committed: https://crrev.com/43c6a582d94fe6ec49330636c819601650f63a24
Cr-Commit-Position: refs/heads/master@{#439253}

[stevenjb, 2016-12-15 22:59:20]

Description was changed from

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153
==========

to

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304
==========

[stevenjb, 2016-12-15 22:59:20]

stevenjb@chromium.org changed reviewers:
+ emaxx@chromium.org, mcasas@chromium.org

[stevenjb, 2016-12-15 23:00:40]

Tested with these instructions to confirm that this fixes the DCHECK:

https://bugs.chromium.org/p/chromium/issues/detail?id=674153#c8

[emaxx, 2016-12-16 00:13:22]

lgtm

Thanks for quick fix!

https://codereview.chromium.org/2584733002/diff/1/device/geolocation/wifi_dat...
File device/geolocation/wifi_data_provider_chromeos.cc (right):

https://codereview.chromium.org/2584733002/diff/1/device/geolocation/wifi_dat...
device/geolocation/wifi_data_provider_chromeos.cc:18: using
chromeos::NetworkHandler;
nit: #include "chromeos/network/network_handler.h"?

[stevenjb, 2016-12-16 18:56:42]

https://codereview.chromium.org/2584733002/diff/1/device/geolocation/wifi_dat...
File device/geolocation/wifi_data_provider_chromeos.cc (right):

https://codereview.chromium.org/2584733002/diff/1/device/geolocation/wifi_dat...
device/geolocation/wifi_data_provider_chromeos.cc:18: using
chromeos::NetworkHandler;
On 2016/12/16 00:13:22, emaxx wrote:
> nit: #include "chromeos/network/network_handler.h"?

Done.

[mcasas, 2016-12-16 22:46:26]

lgtm

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
File device/geolocation/wifi_data_provider_chromeos.cc (right):

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
device/geolocation/wifi_data_provider_chromeos.cc:12: #include
"base/single_thread_task_runner.h"
Probably not needed now.

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
device/geolocation/wifi_data_provider_chromeos.cc:133: LOG(ERROR) <<
"ScheduleStart called with uninitialized NetworkHandler";
nit: DLOG()?

[stevenjb, 2016-12-16 23:03:35]

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
File device/geolocation/wifi_data_provider_chromeos.cc (right):

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
device/geolocation/wifi_data_provider_chromeos.cc:12: #include
"base/single_thread_task_runner.h"
On 2016/12/16 22:46:26, mcasas wrote:
> Probably not needed now.

Done.

https://codereview.chromium.org/2584733002/diff/20001/device/geolocation/wifi...
device/geolocation/wifi_data_provider_chromeos.cc:133: LOG(ERROR) <<
"ScheduleStart called with uninitialized NetworkHandler";
On 2016/12/16 22:46:26, mcasas wrote:
> nit: DLOG()?

I'd just as soon log this if it is happening (e.g. because we are initializing
this before we initialize NetworkHandler). It could potentially prevent this
from working as expected (I'm not sure how the retry logic works), so it might
provide a helpful breadcrumb in the future.

[stevenjb, 2016-12-16 23:03:42]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-12-16 23:03:42]

The patchset sent to the CQ was uploaded after l-g-t-m from emaxx@chromium.org,
mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2584733002/#ps40001
(title: "Rebase + Elim unnecessary headers")

[commit-bot: I haz the power, 2016-12-16 23:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 00:37:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481929422105830,
"parent_rev": "360d019f6a0180de171a33041cb9da14b8a24361", "commit_rev":
"28eea2ad94c2c2243e6c09f6c988e592a6ff3a0b"}

[commit-bot: I haz the power, 2016-12-17 00:37:44]

Description was changed from

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304
==========

to

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304

Review-Url: https://codereview.chromium.org/2584733002
==========

[commit-bot: I haz the power, 2016-12-17 00:37:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-17 00:39:58]

Description was changed from

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304

Review-Url: https://codereview.chromium.org/2584733002
==========

to

==========
WifiDataProviderChromeOs: Call NetworkHandler from correct task runner.

At some point, WifiDataProviderChromeOs construction changed to the
GeolocationProviderImpl thread, making the following code in its
constructor incorrect:

main_task_runner_(base::ThreadTaskRunnerHandle::Get())

Rather than relying on a "main" task runner for NetworkHandger calls,
use NetworkHandler::Get()->task_runner() instead.

BUG=674153, 661304

Committed: https://crrev.com/43c6a582d94fe6ec49330636c819601650f63a24
Cr-Commit-Position: refs/heads/master@{#439253}
==========

[commit-bot: I haz the power, 2016-12-17 00:39:59]

Patchset 3 (id:??) landed as
https://crrev.com/43c6a582d94fe6ec49330636c819601650f63a24
Cr-Commit-Position: refs/heads/master@{#439253}