Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2644643011: [builtins] Don't put doubles on the stack in ConstructWithSpread. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Don't put doubles on the stack in ConstructWithSpread. FAST_DOUBLE_ELEMENTS and FAST_HOLEY_DOUBLE_ELEMENTS kinds should both be handled by the runtime. Review-Url: https://codereview.chromium.org/2644643011 Cr-Commit-Position: refs/heads/master@{#42561} Committed: https://chromium.googlesource.com/v8/v8/+/ee9c709190b1a5a8c32fbcffb33f8ebe5cb20673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
petermarshall
PTAL =]
3 years, 11 months ago (2017-01-20 13:51:46 UTC) #4
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-20 13:53:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644643011/1
3 years, 11 months ago (2017-01-20 14:02:10 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 14:04:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ee9c709190b1a5a8c32fbcffb33f8ebe5cb...

Powered by Google App Engine
This is Rietveld 408576698