Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: src/builtins/ppc/builtins-ppc.cc

Issue 2644643011: [builtins] Don't put doubles on the stack in ConstructWithSpread. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/mips64/builtins-mips64.cc ('k') | src/builtins/s390/builtins-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 2840 matching lines...) Expand 10 before | Expand all | Expand 10 after
2851 ContextMemOperand( 2851 ContextMemOperand(
2852 scratch2, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX)); 2852 scratch2, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX));
2853 __ cmp(scratch, scratch2); 2853 __ cmp(scratch, scratch2);
2854 __ bne(&runtime_call); 2854 __ bne(&runtime_call);
2855 2855
2856 // For FastPacked kinds, iteration will have the same effect as simply 2856 // For FastPacked kinds, iteration will have the same effect as simply
2857 // accessing each property in order. 2857 // accessing each property in order.
2858 Label no_protector_check; 2858 Label no_protector_check;
2859 __ LoadP(scratch, FieldMemOperand(spread_map, Map::kBitField2Offset)); 2859 __ LoadP(scratch, FieldMemOperand(spread_map, Map::kBitField2Offset));
2860 __ DecodeField<Map::ElementsKindBits>(scratch); 2860 __ DecodeField<Map::ElementsKindBits>(scratch);
2861 __ cmpi(scratch, Operand(LAST_FAST_ELEMENTS_KIND)); 2861 __ cmpi(scratch, Operand(FAST_HOLEY_ELEMENTS));
2862 __ bgt(&runtime_call); 2862 __ bgt(&runtime_call);
2863 // For non-FastHoley kinds, we can skip the protector check. 2863 // For non-FastHoley kinds, we can skip the protector check.
2864 __ cmpi(scratch, Operand(FAST_SMI_ELEMENTS)); 2864 __ cmpi(scratch, Operand(FAST_SMI_ELEMENTS));
2865 __ beq(&no_protector_check); 2865 __ beq(&no_protector_check);
2866 __ cmpi(scratch, Operand(FAST_ELEMENTS)); 2866 __ cmpi(scratch, Operand(FAST_ELEMENTS));
2867 __ beq(&no_protector_check); 2867 __ beq(&no_protector_check);
2868 __ cmpi(scratch, Operand(FAST_DOUBLE_ELEMENTS));
2869 __ beq(&no_protector_check);
2870 // Check the ArrayProtector cell. 2868 // Check the ArrayProtector cell.
2871 __ LoadRoot(scratch, Heap::kArrayProtectorRootIndex); 2869 __ LoadRoot(scratch, Heap::kArrayProtectorRootIndex);
2872 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset)); 2870 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
2873 __ CmpSmiLiteral(scratch, Smi::FromInt(Isolate::kProtectorValid), r0); 2871 __ CmpSmiLiteral(scratch, Smi::FromInt(Isolate::kProtectorValid), r0);
2874 __ bne(&runtime_call); 2872 __ bne(&runtime_call);
2875 2873
2876 __ bind(&no_protector_check); 2874 __ bind(&no_protector_check);
2877 // Load the FixedArray backing store. 2875 // Load the FixedArray backing store.
2878 __ LoadP(spread, FieldMemOperand(spread, JSArray::kElementsOffset)); 2876 __ LoadP(spread, FieldMemOperand(spread, JSArray::kElementsOffset));
2879 __ b(&push_args); 2877 __ b(&push_args);
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
3106 __ CallRuntime(Runtime::kThrowStackOverflow); 3104 __ CallRuntime(Runtime::kThrowStackOverflow);
3107 __ bkpt(0); 3105 __ bkpt(0);
3108 } 3106 }
3109 } 3107 }
3110 3108
3111 #undef __ 3109 #undef __
3112 } // namespace internal 3110 } // namespace internal
3113 } // namespace v8 3111 } // namespace v8
3114 3112
3115 #endif // V8_TARGET_ARCH_PPC 3113 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/builtins/mips64/builtins-mips64.cc ('k') | src/builtins/s390/builtins-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698